Skip to content

/node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: change inspect depth default #17907

Closed
wants to merge 7 commits into from

Conversation

Reviewers

@addaleax addaleax

@lpinca lpinca

@TimothyGu TimothyGu

@mcollina mcollina

@jasnell jasnell

@targos targos

Assignees
No one assigned
Labels
console repl semver-major util
Projects
None yet
Milestone
No milestone
@BridgeAR
Copy link
Member

BridgeAR commented Dec 28, 2017

Right now the defaults for util.inspect are often not ideal. This is a first step to improve those. I tried not to break to much and keep the current behavior for the repl and console.

Refs: #12693

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

util, console

@nodejs-github-bot nodejs-github-bot added console repl util labels Dec 28, 2017

@BridgeAR BridgeAR added the semver-major label Dec 28, 2017

@lpinca

lpinca reviewed Dec 29, 2017
View changes

lib/util.js
@@ -317,7 +317,9 @@ Object.defineProperty(inspect, 'defaultOptions', {
if (options === null || typeof options !== 'object') {
throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'options', 'Object');
}
Object.assign(inspectDefaultOptions, options);

This comment has been minimized.

Sign in to view
Copy link
@lpinca

lpinca Dec 29, 2017

Member

Any reason for not using _extend?

This comment has been minimized.

Sign in to view
Copy link
@BridgeAR

BridgeAR Dec 29, 2017

Author Member

The type check has to be done again in that case.

This comment has been minimized.

Sign in to view
Copy link
@lpinca

lpinca Dec 29, 2017

Member

I doubt it will add a noticeable overhead but yes it makes sense.

This comment has been minimized.

Sign in to view
Copy link
@TimothyGu

TimothyGu Dec 30, 2017

Member
  1. Do we actually care about the performance of inspection? I thought we didn’t.
  2. Same concern here as @lpinca. This is quite literally reinventing the wheel, and type checks for object are quite fast in modern V8.

This comment has been minimized.

Sign in to view
Copy link
@BridgeAR

BridgeAR Jan 2, 2018

Author Member

Updated the use _extend as it will still be faster than Object.assign

This comment has been minimized.

Sign in to view
Copy link
@BridgeAR

BridgeAR Jan 2, 2018

Author Member

About the performance - just recently I heard that inspect came up in a flamegraph. Seems like people use it a lot. I am aware that setting the default options will not be a big thing but the first implementation (not changing inspect for console.*) used it a lot and that is why I decided to optimize it as well.
@silverwind

This comment has been minimized.

Sign in to view
Copy link
Contributor

silverwind commented Dec 29, 2017

Not sure I like the complexity introduced here. Given that this is already flagged as semver-major, why not update it to 5 (I'd leave that value open to discussion, but it's certainly more useful than the current 2) everywhere via new defaults?
@BridgeAR

This comment has been minimized.

Sign in to view
Copy link
Member Author

BridgeAR commented Dec 29, 2017 •
edited

@silverwind I do not see a big difference between 5 and unlimited. Most entries are not that deeply nested and if they are, you likely want to see everything. To prevent huge diffs, the max array entries option is way more efficient as this would otherwise be more difficult to handle.

About the complexity: I am fine with showing everything as a new default for console.* and this would remove the complexity again. But it would be a more significant change and I tried to minimize the breaking change.

For the repl it might be best to stay with the current default though. The reason is that some modules like fs have lots of nested elements and it would be be verbose otherwise.
@jasnell

jasnell approved these changes Dec 29, 2017
View changes

@BridgeAR

This comment has been minimized.

Sign in to view
Copy link
Member Author

BridgeAR commented Dec 29, 2017

@jasnell what do you think about removing the limit for console.* as well? I guess most people would actually profit from that.
@jasnell

This comment has been minimized.

Sign in to view
Copy link
Member

jasnell commented Dec 29, 2017

Changing the default for console.* should be ok given that this is semver-major

BridgeAR added some commits Dec 30, 2017

@BridgeAR
streams: add custom inspect to BufferList 
Currently inspecting the BufferList can result a maximum call stack
size error. Adding a individual inspect function prevents this.
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
94b7b01
@BridgeAR
util: change util.inspect depth default 
The current default is not ideal in most use cases. Therefore it is
changed to showing unlimited depth in case util.inspect is called
directly. The default is kept as before for console.log and similar.

Using console.dir will now show a depth of up to five and
console.assert / console.trace will show a unlimited depth.
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
2d845cf
@BridgeAR
util: improve setting default options 
Object.assign is currently very slow. Using Object.keys is much
faster in v8 6.3.
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
Loading status checks…
2721767

@BridgeAR BridgeAR force-pushed the BridgeAR:change-inspect-defaults branch from 2bb38d6 to 2721767 Dec 30, 2017

@BridgeAR

This comment has been minimized.

Sign in to view
Copy link
Member Author

BridgeAR commented Dec 30, 2017

I changed the code to default to unlimited for the console functions as well.
To make that work I had to add a custom inspect function to the BufferList.

CITGM https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1179/
CI https://ci.nodejs.org/job/node-test-pull-request/12350/
@TimothyGu

TimothyGu reviewed Dec 30, 2017
View changes

lib/internal/streams/BufferList.js Outdated
@@ -73,4 +74,8 @@ module.exports = class BufferList {
}
return ret;
}

[customInspectSymbol]() {
return `${this.constructor.name} { length: ${this.length} }`;

This comment has been minimized.

Sign in to view
Copy link
@TimothyGu

TimothyGu Dec 30, 2017

Member

You could return { __proto__: Object.getPrototypeOf(this), length: this.length } which would also give coloring etc. for free.

This comment has been minimized.

Sign in to view
Copy link
@BridgeAR

BridgeAR Jan 2, 2018

Author Member

Using __proto__ will actually result in a `call stack size exceeded error. I decided to call inspect directly instead to highlight the color in case it is needed.
lib/util.js
@@ -317,7 +317,9 @@ Object.defineProperty(inspect, 'defaultOptions', {
if (options === null || typeof options !== 'object') {
throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'options', 'Object');
}
Object.assign(inspectDefaultOptions, options);

This comment has been minimized.

Sign in to view
Copy link
@TimothyGu

TimothyGu Dec 30, 2017

Member
  1. Do we actually care about the performance of inspection? I thought we didn’t.
  2. Same concern here as @lpinca. This is quite literally reinventing the wheel, and type checks for object are quite fast in modern V8.

@starkwang starkwang referenced this pull request Dec 30, 2017

Closed

Some jenkins jobs failed to push state. #163

@BridgeAR
fixup address comments
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
Loading status checks…
606f06c
@BridgeAR

This comment has been minimized.

Sign in to view
Copy link
Member Author

BridgeAR commented Jan 2, 2018

New CI https://ci.nodejs.org/job/node-test-pull-request/12363/

@BridgeAR BridgeAR added author ready and removed author ready labels Jan 2, 2018

@BridgeAR BridgeAR requested a review from nodejs/tsc Jan 2, 2018

@mcollina

mcollina approved these changes Jan 2, 2018
View changes

Copy link
Member

mcollina left a comment

LGTM
@targos

targos requested changes Jan 2, 2018
View changes

Copy link
Member

targos left a comment

Can you please change the documentation of util.inspect (and add an entry to its history)?
@addaleax

addaleax reviewed Jan 2, 2018
View changes

lib/internal/streams/BufferList.js Outdated
@@ -73,4 +75,9 @@ module.exports = class BufferList {
}
return ret;
}

[customInspectSymbol]() {

This comment has been minimized.

Sign in to view
Copy link
@addaleax

addaleax Jan 2, 2018

Member

I’d just use util.inspect.custom here, it saves people looking at this code one round-trip to another file

This comment has been minimized.

Sign in to view
Copy link
@BridgeAR

BridgeAR Jan 3, 2018

Author Member

Done

BridgeAR added some commits Jan 3, 2018

@BridgeAR
fixup update documentation
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
3ca34ca
@BridgeAR
util: change %o depth default 
Since the default for depth is changed to `Infinity` it is logical
to change the %o default to the same as well.

Using %o with `util.format` will now always print the whole object.
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
8ab8726
@BridgeAR

This comment has been minimized.

Sign in to view
Copy link
Member Author

BridgeAR commented Jan 3, 2018

I updated the documentation and added the history entry. I also changed the %o default of util.format to also use Infinity as default.
@targos

targos approved these changes Jan 7, 2018
View changes

doc/api/util.md Outdated
* `depth` {number} Specifies the number visible nested Objects in an `object`.
This is useful to minimize the inspection output for large complicated
objects. To make it recurse indefinitely pass `null` or `Infinity`. Defaults
to `null`.

This comment has been minimized.

Sign in to view
Copy link
@targos

targos Jan 7, 2018

Member

suggestion: Infinity instead of null to match the changelog?
@BridgeAR
fixup
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
Loading status checks…
e220598

shisama added a commit to shisama/node that referenced this pull request May 13, 2018

@addaleax @shisama
Revert "util: change %o depth default" 
This reverts commit 8f15309.

PR-URL: nodejs#20017
Refs: nodejs#17907
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
d16ab60

shisama added a commit to shisama/node that referenced this pull request May 13, 2018

@addaleax @shisama
Revert "util: change util.inspect depth default" 
This reverts commit b994b8e.

This caused regressions in ecosystem code. While the change originally
was semver-major and could be postponed until after Node.js 10,
I think reverting it is a good choice at this point.

Also, I personally do not think defaulting to a shallow inspect
is a bad thing at all – quite the opposite: It makes `util.inspect()`
give an overview of an object, rather than providing a full
display of its contents. Changing the `depth` default to infinity
fundamentally changed the role that `util.inspect()` plays,
and makes output much more verbose and thus at times unusable
for `console.log()`-style debugging.

PR-URL: nodejs#20017
Fixes: nodejs#19405
Refs: nodejs#17907
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
5f2da80

shisama added a commit to shisama/node that referenced this pull request May 30, 2018

@addaleax @shisama
Revert "util: change %o depth default" 
This reverts commit 8f15309.

PR-URL: nodejs#20017
Refs: nodejs#17907
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
4518bf6

shisama added a commit to shisama/node that referenced this pull request May 30, 2018

@addaleax @shisama
Revert "util: change util.inspect depth default" 
This reverts commit b994b8e.

This caused regressions in ecosystem code. While the change originally
was semver-major and could be postponed until after Node.js 10,
I think reverting it is a good choice at this point.

Also, I personally do not think defaulting to a shallow inspect
is a bad thing at all – quite the opposite: It makes `util.inspect()`
give an overview of an object, rather than providing a full
display of its contents. Changing the `depth` default to infinity
fundamentally changed the role that `util.inspect()` plays,
and makes output much more verbose and thus at times unusable
for `console.log()`-style debugging.

PR-URL: nodejs#20017
Fixes: nodejs#19405
Refs: nodejs#17907
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
8232a38

shisama added a commit to shisama/node that referenced this pull request May 30, 2018

@addaleax @shisama
Revert "util: change %o depth default" 
This reverts commit 8f15309.

PR-URL: nodejs#20017
Refs: nodejs#17907
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
e019979

shisama added a commit to shisama/node that referenced this pull request May 30, 2018

@addaleax @shisama
Revert "util: change util.inspect depth default" 
This reverts commit b994b8e.

This caused regressions in ecosystem code. While the change originally
was semver-major and could be postponed until after Node.js 10,
I think reverting it is a good choice at this point.

Also, I personally do not think defaulting to a shallow inspect
is a bad thing at all – quite the opposite: It makes `util.inspect()`
give an overview of an object, rather than providing a full
display of its contents. Changing the `depth` default to infinity
fundamentally changed the role that `util.inspect()` plays,
and makes output much more verbose and thus at times unusable
for `console.log()`-style debugging.

PR-URL: nodejs#20017
Fixes: nodejs#19405
Refs: nodejs#17907
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
43ff786

shisama added a commit to shisama/node that referenced this pull request Jun 5, 2018

@addaleax @shisama
Revert "util: change %o depth default" 
This reverts commit 8f15309.

PR-URL: nodejs#20017
Refs: nodejs#17907
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
ea21b54

shisama added a commit to shisama/node that referenced this pull request Jun 5, 2018

@addaleax @shisama
Revert "util: change util.inspect depth default" 
This reverts commit b994b8e.

This caused regressions in ecosystem code. While the change originally
was semver-major and could be postponed until after Node.js 10,
I think reverting it is a good choice at this point.

Also, I personally do not think defaulting to a shallow inspect
is a bad thing at all – quite the opposite: It makes `util.inspect()`
give an overview of an object, rather than providing a full
display of its contents. Changing the `depth` default to infinity
fundamentally changed the role that `util.inspect()` plays,
and makes output much more verbose and thus at times unusable
for `console.log()`-style debugging.

PR-URL: nodejs#20017
Fixes: nodejs#19405
Refs: nodejs#17907
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
db73739

@targos targos removed the dont-land-on-v10.x label Jun 8, 2018

shisama added a commit to shisama/node that referenced this pull request Jun 9, 2018

@addaleax @shisama
Revert "util: change %o depth default" 
This reverts commit 8f15309.

PR-URL: nodejs#20017
Refs: nodejs#17907
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
e2210e8

shisama added a commit to shisama/node that referenced this pull request Jun 9, 2018

@addaleax @shisama
Revert "util: change util.inspect depth default" 
This reverts commit b994b8e.

This caused regressions in ecosystem code. While the change originally
was semver-major and could be postponed until after Node.js 10,
I think reverting it is a good choice at this point.

Also, I personally do not think defaulting to a shallow inspect
is a bad thing at all – quite the opposite: It makes `util.inspect()`
give an overview of an object, rather than providing a full
display of its contents. Changing the `depth` default to infinity
fundamentally changed the role that `util.inspect()` plays,
and makes output much more verbose and thus at times unusable
for `console.log()`-style debugging.

PR-URL: nodejs#20017
Fixes: nodejs#19405
Refs: nodejs#17907
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
43b328e

shisama added a commit to shisama/node that referenced this pull request Jun 11, 2018

@addaleax @shisama
Revert "util: change %o depth default" 
This reverts commit 8f15309.

PR-URL: nodejs#20017
Refs: nodejs#17907
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
87e7fac

shisama added a commit to shisama/node that referenced this pull request Jun 11, 2018

@addaleax @shisama
Revert "util: change util.inspect depth default" 
This reverts commit b994b8e.

This caused regressions in ecosystem code. While the change originally
was semver-major and could be postponed until after Node.js 10,
I think reverting it is a good choice at this point.

Also, I personally do not think defaulting to a shallow inspect
is a bad thing at all – quite the opposite: It makes `util.inspect()`
give an overview of an object, rather than providing a full
display of its contents. Changing the `depth` default to infinity
fundamentally changed the role that `util.inspect()` plays,
and makes output much more verbose and thus at times unusable
for `console.log()`-style debugging.

PR-URL: nodejs#20017
Fixes: nodejs#19405
Refs: nodejs#17907
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
46e5145

shisama added a commit to shisama/node that referenced this pull request Jun 12, 2018

@addaleax @shisama
Revert "util: change %o depth default" 
This reverts commit 8f15309.

PR-URL: nodejs#20017
Refs: nodejs#17907
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
d33d2ff

shisama added a commit to shisama/node that referenced this pull request Jun 12, 2018

@addaleax @shisama
Revert "util: change util.inspect depth default" 
This reverts commit b994b8e.

This caused regressions in ecosystem code. While the change originally
was semver-major and could be postponed until after Node.js 10,
I think reverting it is a good choice at this point.

Also, I personally do not think defaulting to a shallow inspect
is a bad thing at all – quite the opposite: It makes `util.inspect()`
give an overview of an object, rather than providing a full
display of its contents. Changing the `depth` default to infinity
fundamentally changed the role that `util.inspect()` plays,
and makes output much more verbose and thus at times unusable
for `console.log()`-style debugging.

PR-URL: nodejs#20017
Fixes: nodejs#19405
Refs: nodejs#17907
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
c3be15e

shisama added a commit to shisama/node that referenced this pull request Jun 17, 2018

@addaleax @shisama
Revert "util: change %o depth default" 
This reverts commit 8f15309.

PR-URL: nodejs#20017
Refs: nodejs#17907
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
41f86c6

shisama added a commit to shisama/node that referenced this pull request Jun 17, 2018

@addaleax @shisama
Revert "util: change util.inspect depth default" 
This reverts commit b994b8e.

This caused regressions in ecosystem code. While the change originally
was semver-major and could be postponed until after Node.js 10,
I think reverting it is a good choice at this point.

Also, I personally do not think defaulting to a shallow inspect
is a bad thing at all – quite the opposite: It makes `util.inspect()`
give an overview of an object, rather than providing a full
display of its contents. Changing the `depth` default to infinity
fundamentally changed the role that `util.inspect()` plays,
and makes output much more verbose and thus at times unusable
for `console.log()`-style debugging.

PR-URL: nodejs#20017
Fixes: nodejs#19405
Refs: nodejs#17907
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
dc99bd0

BridgeAR added a commit to BridgeAR/node that referenced this pull request Sep 13, 2018

@BridgeAR
util: change util.inspect depth default 
The current default is not ideal in most use cases. Therefore it is
changed to inspect objects to a maximum depth of 20 in case
util.inspect is called with it's defaults. The default is kept at 2
when using console.log() and similar in the repl.

PR-URL: nodejs#17907
Refs: nodejs#12693
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
d2c6e39

BridgeAR added a commit to BridgeAR/node that referenced this pull request Sep 13, 2018

@BridgeAR
util: change %o depth default 
Since the default for depth is changed to `20` it is logical
to change the %o default as well. It will now always use the
default depth.

PR-URL: nodejs#17907
Refs: nodejs#12693
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
38220c3

BridgeAR added a commit to BridgeAR/node that referenced this pull request Sep 13, 2018

@BridgeAR
util: change util.inspect depth default 
The current default is not ideal in most use cases. Therefore it is
changed to inspect objects to a maximum depth of 20 in case
util.inspect is called with it's defaults. The default is kept at 2
when using console.log() and similar in the repl.

PR-URL: nodejs#17907
Refs: nodejs#12693
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
0eb6e27

BridgeAR added a commit to BridgeAR/node that referenced this pull request Sep 13, 2018

@BridgeAR
util: change %o depth default 
Since the default for depth is changed to `20` it is logical
to change the %o default as well. It will now always use the
default depth.

PR-URL: nodejs#17907
Refs: nodejs#12693
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
4c23065

BridgeAR added a commit to BridgeAR/node that referenced this pull request Sep 18, 2018

@BridgeAR
util: change util.inspect depth default 
The current default is not ideal in most use cases. Therefore it is
changed to inspect objects to a maximum depth of 20 in case
util.inspect is called with it's defaults. The default is kept at 2
when using console.log() and similar in the repl.

PR-URL: nodejs#17907
Refs: nodejs#12693
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
4ced2b1

BridgeAR added a commit to BridgeAR/node that referenced this pull request Sep 18, 2018

@BridgeAR
util: change %o depth default 
Since the default for depth is changed to `20` it is logical
to change the %o default as well. It will now always use the
default depth.

PR-URL: nodejs#17907
Refs: nodejs#12693
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
b995c61

BridgeAR added a commit to BridgeAR/node that referenced this pull request Sep 19, 2018

@BridgeAR
util: change util.inspect depth default 
The current default is not ideal in most use cases. Therefore it is
changed to inspect objects to a maximum depth of 20 in case
util.inspect is called with it's defaults. The default is kept at 2
when using console.log() and similar in the repl.

PR-URL: nodejs#17907
Refs: nodejs#12693
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
5c16da5

BridgeAR added a commit to BridgeAR/node that referenced this pull request Sep 19, 2018

@BridgeAR
util: change %o depth default 
Since the default for depth is changed to `20` it is logical
to change the %o default as well. It will now always use the
default depth.

PR-URL: nodejs#17907
Refs: nodejs#12693
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
702cf21

BridgeAR added a commit to BridgeAR/node that referenced this pull request Sep 24, 2018

@BridgeAR
util: change util.inspect depth default 
The current default is not ideal in most use cases. Therefore it is
changed to inspect objects to a maximum depth of 20 in case
util.inspect is called with it's defaults. The default is kept at 2
when using console.log() and similar in the repl.

PR-URL: nodejs#17907
Refs: nodejs#12693
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
b6fa43d

BridgeAR added a commit to BridgeAR/node that referenced this pull request Sep 24, 2018

@BridgeAR
util: change %o depth default 
Since the default for depth is changed to `20` it is logical
to change the %o default as well. It will now always use the
default depth.

PR-URL: nodejs#17907
Refs: nodejs#12693
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
fdfcd24

BridgeAR added a commit to BridgeAR/node that referenced this pull request Oct 2, 2018

@BridgeAR
util: change util.inspect depth default 
The current default is not ideal in most use cases. Therefore it is
changed to inspect objects to a maximum depth of 20 in case
util.inspect is called with it's defaults. The default is kept at 2
when using console.log() and similar in the repl.

PR-URL: nodejs#17907
Refs: nodejs#12693

PR-URL: nodejs#22846
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
ac7450a

BridgeAR added a commit to BridgeAR/node that referenced this pull request Oct 2, 2018

@BridgeAR
util: change %o depth default 
Since the default for depth is changed to `20` it is logical
to change the %o default as well. It will now always use the
default depth.

PR-URL: nodejs#17907
Refs: nodejs#12693

PR-URL: nodejs#22846
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Verified
This commit was signed with a verified signature.
@BridgeAR BridgeAR Ruben Bridgewater
GPG key ID: F07496B3EB3C1762 Learn about signing commits
1a1fe53

@BridgeAR BridgeAR deleted the BridgeAR:change-inspect-defaults branch Apr 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.