Skip to content

/ node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: complete migration to internal/errors #16589

Closed
wants to merge 1 commit into from
Closed

stream: complete migration to internal/errors #16589

wants to merge 1 commit into from

Conversation

@mcollina
Copy link
Member

@mcollina mcollina commented Oct 29, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

stream
@mcollina mcollina requested review from jasnell, BridgeAR and nodejs/tsc Oct 29, 2017
@mcollina
Copy link
Member Author

@mcollina mcollina commented Oct 29, 2017

@nodejs/tsc this needs expedite, as we need it for the 9 release. I'm sorry, but I caught these just now.
@addaleax
addaleax approved these changes Oct 29, 2017
View changes
@mcollina
Copy link
Member Author

@mcollina mcollina commented Oct 29, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11075/
@addaleax
Copy link
Member

@addaleax addaleax commented Oct 29, 2017

I think @jasnell wanted to build the binaries ~ now? I’m okay with expediting but maybe we have the time for a CITGM run as well?
@jasnell
jasnell approved these changes Oct 29, 2017
View changes
Copy link
Member

@jasnell jasnell left a comment

One bit but generally lgtm and +1 on fast tracking
lib/_stream_readable.js Outdated
@@ -284,7 +284,7 @@ function chunkInvalid(state, chunk) {
typeof chunk !== 'string' &&
chunk !== undefined &&
!state.objectMode) {
er = new TypeError('Invalid non-string/buffer chunk');
er = new errors.TypeError('ERR_STREAM_INVALID_CHUNK');

This comment has been minimized.

Sign in to view
@jasnell

jasnell Oct 29, 2017
Member

Should probably just use ERR_INVALID_ARG_TYPE here
lib/_stream_writable.js Outdated
} else if (typeof chunk !== 'string' &&
chunk !== undefined &&
!state.objectMode) {
er = new TypeError('Invalid non-string/buffer chunk');
er = new errors.TypeError('ERR_STREAM_INVALID_CHUNK');

This comment has been minimized.

Sign in to view
@jasnell

jasnell Oct 29, 2017
Member

And here
@mcollina
Copy link
Member Author

@mcollina mcollina commented Oct 29, 2017

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1031/
@joyeecheung
joyeecheung approved these changes Oct 29, 2017
View changes
doc/api/errors.md
<a id="ERR_STREAM_CANNOT_PIPE"></a>
### ERR_STREAM_CANNOT_PIPE

Used when an attempt is made to call [`stream.pipe()`][] on a

This comment has been minimized.

Sign in to view
@joyeecheung

joyeecheung Oct 29, 2017
Member

Missing link definitions, so are Writable and stream.write()

This comment has been minimized.

Sign in to view
@mcollina

mcollina Oct 29, 2017
Author Member

added
@mcollina mcollina mentioned this pull request Oct 29, 2017
Merged
@mcollina
stream: complete migration to internal/errors
Loading status checks…
2651f29 
Complete the migration to the new error system of _stream_readable
and _stream_writable. Adds the corresponding documentation.
@mcollina mcollina force-pushed the mcollina:stream-new-errors branch to 2651f29 Oct 29, 2017
@mcollina
Copy link
Member Author

@mcollina mcollina commented Oct 29, 2017

@addaleax @joyeecheung @jasnell updated.

CI: https://ci.nodejs.org/job/node-test-pull-request/11077
@mcollina
Copy link
Member Author

@mcollina mcollina commented Oct 29, 2017

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1032/
@jasnell
Copy link
Member

@jasnell jasnell commented Oct 29, 2017

I'll be doing one final pull from master this afternoon and will be kicking off the release build later on today.
@mcollina
Copy link
Member Author

@mcollina mcollina commented Oct 29, 2017

Landed as 6e86a66
@mcollina mcollina closed this Oct 29, 2017
@mcollina mcollina deleted the mcollina:stream-new-errors branch Oct 29, 2017
mcollina added a commit that referenced this pull request Oct 29, 2017
@mcollina
stream: complete migration to internal/errors
6e86a66 
Complete the migration to the new error system of _stream_readable
and _stream_writable. Adds the corresponding documentation.

PR-URL: #16589
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@maclover7 maclover7 mentioned this pull request Oct 29, 2017
Closed
2 of 2 tasks complete
Qard added a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
@mcollina @Qard
stream: complete migration to internal/errors
b488fa8 
Complete the migration to the new error system of _stream_readable
and _stream_writable. Adds the corresponding documentation.

PR-URL: nodejs/node#16589
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Qard added a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
@mcollina @Qard
stream: complete migration to internal/errors
f470c31 
Complete the migration to the new error system of _stream_readable
and _stream_writable. Adds the corresponding documentation.

PR-URL: nodejs/node#16589
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
addaleax added a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@mcollina @addaleax
stream: complete migration to internal/errors
Verified
This commit was signed with a verified signature.
addaleax Anna Henningsen
GPG key ID: 9C63F3A6CD2AD8F9 Learn about signing commits
19fbfbd 
Complete the migration to the new error system of _stream_readable
and _stream_writable. Adds the corresponding documentation.

PR-URL: nodejs/node#16589
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@kjin kjin mentioned this pull request May 1, 2018
Closed
3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@addaleax addaleax

@joyeecheung joyeecheung

@BridgeAR BridgeAR

Assignees
No one assigned
Labels
errors semver-major stream
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@mcollina @addaleax @jasnell @joyeecheung @nodejs-github-bot
You can’t perform that action at this time.