Skip to content

Fix grammar in Doc/tutorial/controlflow.rst#21885

Merged
miss-islington merged 1 commit intopython:masterfrom
infrastation:master
Aug 19, 2020
Merged

Fix grammar in Doc/tutorial/controlflow.rst#21885
miss-islington merged 1 commit intopython:masterfrom
infrastation:master

Conversation

@infrastation
Copy link
Contributor

@infrastation infrastation commented Aug 14, 2020 •
edited by miss-islington
Loading

Automerge-Triggered-By: @csabella

@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Aug 14, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@infrastation

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Aug 14, 2020
@infrastation
Copy link
Contributor Author

infrastation commented Aug 14, 2020

Updated the BPO user account and submitted the CLA.

tirkarthi
tirkarthi approved these changes Aug 16, 2020
View reviewed changes
Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@miss-islington
Copy link
Contributor

miss-islington commented Aug 19, 2020

Sorry, I can't merge this PR. Reason: Required status check "Travis CI - Pull Request" is expected..

@csabella
Copy link
Contributor

csabella commented Aug 19, 2020

Closing to re-trigger Travis CI.

@csabella csabella closed this Aug 19, 2020
@csabella csabella reopened this Aug 19, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Aug 19, 2020

@infrastation: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor

miss-islington commented Aug 19, 2020

@infrastation: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor

miss-islington commented Aug 19, 2020

Sorry, I can't merge this PR. Reason: Required status check "Travis CI - Pull Request" is expected..

1 similar comment
@miss-islington
Copy link
Contributor

miss-islington commented Aug 19, 2020

Sorry, I can't merge this PR. Reason: Required status check "Travis CI - Pull Request" is expected..

@miss-islington
Copy link
Contributor

miss-islington commented Aug 19, 2020

@infrastation: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 0be7c21 into python:master Aug 19, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Aug 19, 2020

Thanks @infrastation for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 19, 2020
@infrastation @miss-islington
Fix grammar in Doc/tutorial/controlflow.rst (pythonGH-21885)
1eacd53 
Automerge-Triggered-By: @csabella
(cherry picked from commit 0be7c21)

Co-authored-by: Denis Ovsienko <denis@ovsienko.info>
@bedevere-bot
Copy link

bedevere-bot commented Aug 19, 2020

GH-21922 is a backport of this pull request to the 3.9 branch.

@bedevere-bot
Copy link

bedevere-bot commented Aug 19, 2020

GH-21923 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 19, 2020
@infrastation @miss-islington
Fix grammar in Doc/tutorial/controlflow.rst (pythonGH-21885)
ec14c1e 
Automerge-Triggered-By: @csabella
(cherry picked from commit 0be7c21)

Co-authored-by: Denis Ovsienko <denis@ovsienko.info>
@tirkarthi
Copy link
Member

tirkarthi commented Aug 19, 2020

Thanks @infrastation for your contribution :) Thanks @csabella for taking care of this :)

csabella pushed a commit that referenced this pull request Aug 22, 2020
@miss-islington @infrastation
Fix grammar in Doc/tutorial/controlflow.rst (GH-21885) (#21923)
e94d5db 
Automerge-Triggered-By: @csabella
(cherry picked from commit 0be7c21)

Co-authored-by: Denis Ovsienko <denis@ovsienko.info>
csabella pushed a commit that referenced this pull request Aug 22, 2020
@miss-islington @infrastation
Fix grammar in Doc/tutorial/controlflow.rst (GH-21885) (#21922)
72d5ddb 
Automerge-Triggered-By: @csabella
(cherry picked from commit 0be7c21)

Co-authored-by: Denis Ovsienko <denis@ovsienko.info>
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@infrastation
Fix grammar in Doc/tutorial/controlflow.rst (pythonGH-21885)
d0b19e9 
Automerge-Triggered-By: @csabella
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirkarthi tirkarthi tirkarthi approved these changes

+1 more reviewer

@eamanu eamanu eamanu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@infrastation @the-knights-who-say-ni @miss-islington @csabella @bedevere-bot @tirkarthi @eamanu