nodejs / docker-node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove old signing keys #1291

Merged

PeterDaveHello merged 1 commit into master from nschonni-key-cleanup

Jul 22, 2020

Member

nschonni commented Jul 17, 2020

Since the images that would need these old keys are out of support, we should be able to drop them now to shrink the generated Dockerfiles a little.

I just copied the current ordering from https://github.com/nodejs/node/#release-keys along with @richardlau new key that is being PR'd to that file right now


        chore: Remove old signing keys

5fdf90d

PeterDaveHello requested changes

Member

PeterDaveHello left a comment

Would you please also mention that some new keys are added, in the commit message and PR subject? It'll make the change history more accurate and clear, thanks.

PeterDaveHello reviewed

  
        A48C2BEE680E841632CD4E44F07496B3EB3C1762

        B9E2F5981AA6E0CD28160D9FF13993A75599653C

        C82FA3AE1CBEDC6BE46B9360C43CEC45C17AB93C

PeterDaveHello Jul 21, 2020 Member

Not sure the reason to change the order here 🤔

richardlau Jul 21, 2020 Member

It might make it easier to keep in sync with the list of keys in https://github.com/nodejs/node/#release-keys (where it's ordered by the name of the releaser the key belongs to).

SimenB Jul 21, 2020 Member

Should be some script ideally that dumps from that repo, sorts and inserts somewhere in this repo for consumption

Member Author

nschonni commented Jul 21, 2020

@PeterDaveHello there are no keys added, the new lines are from sorting them to match the upstream source

Removed:

FD3A5288F042B6850C66B31F09FE44734EB7990E
B9AE9905FFD7803F25714661B63B535A4C206CA9
77984A986EBC2AA786BC0F66B01FBB92821C587A

Member

PeterDaveHello commented Jul 22, 2020

@nschonni you're right, just misunderstood because of the ordering, maybe can also mention that the next time ;)

PeterDaveHello approved these changes

PeterDaveHello approved these changes

PeterDaveHello merged commit 9b880e7 into master

3 checks passed

3 checks passed

eclint

Details

Travis CI - Branch Build Passed

Details

Travis CI - Pull Request Build Passed

Details

PeterDaveHello deleted the nschonni-key-cleanup branch

PeterDaveHello mentioned this pull request

Add update-keys.sh for nodejs release keys update #1297

Merged

PeterDaveHello added a commit to PeterDaveHello/docker-node that referenced this pull request


        Update node.js v14 from 14.6.0 to 14.7.0

eb55191

Node.js release keys were also updated, see nodejs#1291 nodejs#1290

- https://nodejs.org/en/blog/release/v14.7.0/
- https://github.com/nodejs/node/releases/tag/v14.7.0
- https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V14.md#14.7.0

PeterDaveHello mentioned this pull request

Update node.js v14 from 14.6.0 to 14.7.0 #1304

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.