Skip to content

/ docker-node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update v14.7.0 to v14.8.0 #1311

Merged
merged 1 commit into from Aug 12, 2020
Merged

feat: Update v14.7.0 to v14.8.0 #1311

merged 1 commit into from Aug 12, 2020

Conversation

@nschonni
Copy link
Member

nschonni commented Aug 11, 2020

No description provided.

@nschonni
feat: Update v14.7.0 to v14.8.0
Loading status checks…
afee5ce
@nschonni nschonni requested a review from nodejs/docker Aug 11, 2020
@SimenB
SimenB approved these changes Aug 12, 2020
View changes
@MylesBorins
Copy link
Member

MylesBorins commented Aug 12, 2020

Is there anything blocking this landing? Been pinged a couple times on twitter about this.
@SimenB SimenB merged commit 4798f99 into nodejs:master Aug 12, 2020
2 checks passed
2 checks passed
eclint
Details
Travis CI - Pull Request Build Passed
Details
@SimenB
Copy link
Member

SimenB commented Aug 12, 2020

Is there anything blocking this landing?

Nope 🙂 We should probably have better automation for these PRs...
@MylesBorins
Copy link
Member

MylesBorins commented Aug 12, 2020

@SimenB happy to help figure out how we could do this. Does landing the PR automate the publish? I'll open an issue
@nodejs-github-bot nodejs-github-bot mentioned this pull request Aug 12, 2020
Merged
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 12, 2020

Created PR to the official-images repo (docker-library/official-images#8538). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub.
@SimenB
Copy link
Member

SimenB commented Aug 12, 2020

@MylesBorins thanks! As you can see from the bot message, just landing the PR takes care of opening a PR with docker. It's sending the update PR (mostly just running ./update.sh 14 or whatever) and landing it that are the manual steps
@nschonni nschonni deleted the nschonni:v14.8.0 branch Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimenB SimenB

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@nschonni @MylesBorins @SimenB @nodejs-github-bot
You can’t perform that action at this time.