Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-41467: Fix asyncio recv_into() on Windows #21720

Merged
merged 1 commit into from Aug 4, 2020
Merged

bpo-41467: Fix asyncio recv_into() on Windows #21720

merged 1 commit into from Aug 4, 2020

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Aug 3, 2020 •
edited by bedevere-bot

On Windows, fix asyncio recv_into() return value when the socket/pipe
is closed (BrokenPipeError): return 0 rather than an empty byte
string (b'').

https://bugs.python.org/issue41467

@vstinner
bpo-41467: Fix asyncio recv_into() on Windows
bf9bc9d 
On Windows, fix asyncio recv_into() return value when the socket/pipe
is closed (BrokenPipeError): return 0 rather than an empty byte
string (b'').
@vstinner vstinner requested review from 1st1 and asvetlov as code owners Aug 3, 2020
@vstinner
Copy link
Member Author

@vstinner vstinner commented Aug 3, 2020

cc @pitrou

@vstinner
Copy link
Member Author

@vstinner vstinner commented Aug 4, 2020

"Tests / Ubuntu (pull_request) Failing" is unrelated:

0:26:21 load avg: 0.00 [423/423/1] test_ttk_guionly crashed (Exit code 1)
Timeout (0:20:00)!
Thread 0x00007f2b20812080 (most recent call first):
  File "/home/runner/work/cpython/cpython/Lib/tkinter/__init__.py", line 697 in wait_visibility
  File "/home/runner/work/cpython/cpython/Lib/tkinter/test/test_ttk/test_widgets.py", line 452 in test_virtual_event
  File "/home/runner/work/cpython/cpython/Lib/unittest/case.py", line 549 in _callTestMethod

@vstinner vstinner merged commit 602a971 into python:master Aug 4, 2020
9 of 10 checks passed
@vstinner vstinner deleted the asyncio_recv_into branch Aug 4, 2020
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 4, 2020

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 4, 2020
@vstinner @miss-islington
bpo-41467: Fix asyncio recv_into() on Windows (pythonGH-21720)
567009e 
On Windows, fix asyncio recv_into() return value when the socket/pipe
is closed (BrokenPipeError): return 0 rather than an empty byte
string (b'').
(cherry picked from commit 602a971)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Aug 4, 2020

GH-21724 is a backport of this pull request to the 3.9 branch.

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 4, 2020

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 4, 2020
@vstinner @miss-islington
bpo-41467: Fix asyncio recv_into() on Windows (pythonGH-21720)
7f09365 
On Windows, fix asyncio recv_into() return value when the socket/pipe
is closed (BrokenPipeError): return 0 rather than an empty byte
string (b'').
(cherry picked from commit 602a971)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Aug 4, 2020

GH-21726 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this issue Aug 4, 2020
@miss-islington @vstinner
bpo-41467: Fix asyncio recv_into() on Windows (GH-21720)
b934d83 
On Windows, fix asyncio recv_into() return value when the socket/pipe
is closed (BrokenPipeError): return 0 rather than an empty byte
string (b'').
(cherry picked from commit 602a971)

Co-authored-by: Victor Stinner <vstinner@python.org>
miss-islington added a commit that referenced this issue Aug 4, 2020
@miss-islington @vstinner
bpo-41467: Fix asyncio recv_into() on Windows (GH-21720)
1d16229 
On Windows, fix asyncio recv_into() return value when the socket/pipe
is closed (BrokenPipeError): return 0 rather than an empty byte
string (b'').
(cherry picked from commit 602a971)

Co-authored-by: Victor Stinner <vstinner@python.org>
shihai1991 pushed a commit to shihai1991/cpython that referenced this issue Aug 4, 2020
@vstinner @shihai1991
bpo-41467: Fix asyncio recv_into() on Windows (pythonGH-21720)
11c2ff2 
On Windows, fix asyncio recv_into() return value when the socket/pipe
is closed (BrokenPipeError): return 0 rather than an empty byte
string (b'').
nmaynes pushed a commit to nmaynes/cpython that referenced this issue Aug 4, 2020
@vstinner @nmaynes
bpo-41467: Fix asyncio recv_into() on Windows (pythonGH-21720)
cc3e241 
On Windows, fix asyncio recv_into() return value when the socket/pipe
is closed (BrokenPipeError): return 0 rather than an empty byte
string (b'').
shihai1991 pushed a commit to shihai1991/cpython that referenced this issue Aug 20, 2020
@vstinner @shihai1991
bpo-41467: Fix asyncio recv_into() on Windows (pythonGH-21720)
8048788 
On Windows, fix asyncio recv_into() return value when the socket/pipe
is closed (BrokenPipeError): return 0 rather than an empty byte
string (b'').
xzy3 pushed a commit to xzy3/cpython that referenced this issue Oct 18, 2020
@vstinner
bpo-41467: Fix asyncio recv_into() on Windows (pythonGH-21720)
e05270e 
On Windows, fix asyncio recv_into() return value when the socket/pipe
is closed (BrokenPipeError): return 0 rather than an empty byte
string (b'').
chrisburr pushed a commit to chrisburr/cpython that referenced this issue Dec 9, 2020
@vstinner @chrisburr
bpo-41467: Fix asyncio recv_into() on Windows (pythonGH-21720)
26f9895 
On Windows, fix asyncio recv_into() return value when the socket/pipe
is closed (BrokenPipeError): return 0 rather than an empty byte
string (b'').
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1

@asvetlov asvetlov

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vstinner @miss-islington @bedevere-bot @the-knights-who-say-ni