Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
At the moment pull request comments are only hidden inside the extension when the code near to them hasn't been changed (they're not marked as
Outdatedon github.com). The option toResolve conversationhas recently been added to github.com. We should continue showing conversations until they have been marked as resolved.How it looks on dotcom
Here is a comment on the github.com conversation view that is marked as
Outdatedbut that is still visible because it hasn't been resolved.Here is a comment that is visible on the diff view that isn't
Outdated, but that has been resolved.Required APIs
Unfortunately the GraphQL schema that exposes the resolved/unresolved state of comments is under preview.
In order to use use these preview schema together, the API needs to be accessed using the following header:
This isn't supported by GitHub's API explorer but is supported by the GraphiQL app.
You will need to use a GraphQL endpoint of:
Here is a sample query:
{ repository(owner: "github", name: "VisualStudio") { pullRequest(number: 2241) { reviewThreads(first: 100) { nodes { isResolved resolvedBy { name } comments(first: 100) { nodes { path bodyText } } } } } } }Here is a resolved comment thread:
{ "isResolved": true, "resolvedBy": { "name": "Jamie Cansdale" }, "comments": { "nodes": [ { "path": "src/GitHub.App/Services/RepositoryCloneService.cs", "bodyText": "Maybe we should move the log.Error(...) to above DeleteDirectory in case it also throws?" } ] } }The text was updated successfully, but these errors were encountered: