Skip to content

/ VisualStudio

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix displaying errors in GitHub pane. #2173

Merged
merged 2 commits into from Jan 11, 2019
Merged

Fix displaying errors in GitHub pane. #2173

merged 2 commits into from Jan 11, 2019

Conversation

@grokys
Copy link
Contributor

@grokys grokys commented Jan 10, 2019 •
edited by jcansdale

#1787 refactored InfoPanel but didn't update GitHubPaneView with its new behavior. So:

  • Don't initially set infoPanel.Visibility to Collapsed: InfoPanel will handle this itself
  • Set ShowCloseButton to show the x button to close the error

Fixes #2172
Related #2058
@grokys
Fix displaying errors in GitHub pane.
Loading status checks…
c53fa14 
#1787 refactored `InfoPanel` but didn't update `GitHubPaneView` with its new behavior. So:

- Don't initialy set `infoPanel.Visibility` to `Collapsed`: `InfoPanel` will handle this itself
- Set `ShowCloseButton` to show the `x` button to close the error

Fixes #2172
Fixes #2058
@grokys grokys requested a review from jcansdale Jan 10, 2019
@jcansdale
Merge branch 'master' into fixes/2172-github-pane-errors
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
cea5e44
@jcansdale
jcansdale approved these changes Jan 11, 2019
View changes
Copy link
Collaborator

@jcansdale jcansdale left a comment •
edited

If I try to create a PR in a repo that I don't have permissions to push, I see the following.

image

This is a fix for #2172, but the message is a little obtuse for this to fix completely #2058. I'll update the issue and merge. 👍
@jcansdale jcansdale mentioned this pull request Jan 11, 2019
Closed
@jcansdale jcansdale merged commit 6c69aed into master Jan 11, 2019
4 checks passed
4 checks passed
MSBuild Log 0 errors - 779 warnings
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
github.VisualStudio Build #20190110.10 succeeded
Details
@jcansdale jcansdale deleted the fixes/2172-github-pane-errors branch Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcansdale jcansdale

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

No error shown when creating a PR fails
2 participants
@grokys @jcansdale
You can’t perform that action at this time.