Skip to content

/ substrate

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document, clean and stabilise phragmen's behavior with dupe candiadtes and voters. #4593

Open
kianenigma opened this issue Jan 10, 2020 · 2 comments
Open

Document, clean and stabilise phragmen's behavior with dupe candiadtes and voters. #4593

kianenigma opened this issue Jan 10, 2020 · 2 comments
Assignees
@shawntabrizi
Labels
I3-annoyance 🦟 Z1-mentor

Comments

@kianenigma
Copy link
Contributor

@kianenigma kianenigma commented Jan 10, 2020

Both staking and elections should not allow duplicate candidates, but still, it happened #4592. A simple fix should make sure that phragmen is internally also dealing with this, in the proper way. Currently, out of luck, the dupes are being ignored, but it should be done in a more mature manner.
@shawntabrizi shawntabrizi self-assigned this Jan 12, 2020
@shawntabrizi
Copy link
Member

@shawntabrizi shawntabrizi commented Jan 12, 2020

@kianenigma lets do this together this week
@kianenigma
Copy link
Contributor Author

@kianenigma kianenigma commented Jan 15, 2020

More precisely:

  • dupe candidate
  • dupe voter
  • dupe target
@kianenigma kianenigma mentioned this issue Jun 4, 2020
Open
1 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawntabrizi shawntabrizi

Labels
I3-annoyance 🦟 Z1-mentor
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@shawntabrizi @kianenigma
You can’t perform that action at this time.