Created on 2020-06-17 15:20 by christian.heimes, last changed 2020-06-25 12:19 by ned.deily. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 20942 | merged | christian.heimes, 2020-06-17 15:28 | |
| PR 20947 | merged | christian.heimes, 2020-06-17 17:25 | |
| PR 20948 | merged | christian.heimes, 2020-06-17 17:26 | |
| PR 20949 | merged | christian.heimes, 2020-06-17 17:27 | |
| Messages (6) | |||
|---|---|---|---|
| msg371752 - (view) | Author: Christian Heimes (christian.heimes) *  |
Date: 2020-06-17 15:20 | |
The decorators requires_linux_version, requires_freebsd_version, and requires_mac_ver don't work as class decorators. Decorated classes are ignored completely and not used in tests. The problem affects a couple of tests in test_os and maybe more cases. |
|||
| msg371758 - (view) | Author: Christian Heimes (christian.heimes) * |
Date: 2020-06-17 16:34 | |
Clarification: By "ignored" I mean that the entire class is ignored and none of the tests in the class is executed. I ran into the issue when I was working on eventfd PR. |
|||
| msg371763 - (view) | Author: miss-islington (miss-islington) | Date: 2020-06-17 17:09 | |
New changeset bb6ec14479f18c32e71e43f2785f177aa17aabbd by Christian Heimes in branch 'master': bpo-41009: fix requires_OS_version() class decorator (GH-20942) https://github.com/python/cpython/commit/bb6ec14479f18c32e71e43f2785f177aa17aabbd |
|||
| msg372360 - (view) | Author: Ned Deily (ned.deily) * |
Date: 2020-06-25 12:11 | |
New changeset d3798ed9f1762dcf632369505d517f476eccde13 by Christian Heimes in branch '3.7': [3.7] bpo-41009: fix requires_OS_version() class decorator (GH-20942) (GH-20949) https://github.com/python/cpython/commit/d3798ed9f1762dcf632369505d517f476eccde13 |
|||
| msg372362 - (view) | Author: miss-islington (miss-islington) | Date: 2020-06-25 12:18 | |
New changeset cd6f9110974f733d10d9eef36a9a769a29cd3295 by Christian Heimes in branch '3.9': [3.9] bpo-41009: fix requires_OS_version() class decorator (GH-20942) (GH-20947) https://github.com/python/cpython/commit/cd6f9110974f733d10d9eef36a9a769a29cd3295 |
|||
| msg372363 - (view) | Author: miss-islington (miss-islington) | Date: 2020-06-25 12:18 | |
New changeset 8075fe199b0569428cebaf213663bdd1ca40d792 by Christian Heimes in branch '3.8': [3.8] bpo-41009: fix requires_OS_version() class decorator (GH-20942) (GH-20948) https://github.com/python/cpython/commit/8075fe199b0569428cebaf213663bdd1ca40d792 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2020-06-25 12:19:30 | ned.deily | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2020-06-25 12:18:47 | miss-islington | set | messages: + msg372363 |
| 2020-06-25 12:18:09 | miss-islington | set | messages: + msg372362 |
| 2020-06-25 12:11:17 | ned.deily | set | nosy:
+ ned.deily messages: + msg372360 |
| 2020-06-17 17:27:03 | christian.heimes | set | pull_requests: + pull_request20130 |
| 2020-06-17 17:26:24 | christian.heimes | set | pull_requests: + pull_request20129 |
| 2020-06-17 17:25:36 | christian.heimes | set | pull_requests: + pull_request20128 |
| 2020-06-17 17:09:18 | miss-islington | set | nosy:
+ miss-islington messages: + msg371763 |
| 2020-06-17 16:34:37 | christian.heimes | set | messages: + msg371758 |
| 2020-06-17 15:28:43 | christian.heimes | set | keywords:
+ patch stage: patch review pull_requests: + pull_request20123 |
| 2020-06-17 15:20:43 | christian.heimes | create | |