Skip to content

/ VisualStudio

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Field 'timeline' doesn't exist on type 'PullRequest' #2481

Closed
jcansdale opened this issue Mar 18, 2020 · 1 comment
Closed

Field 'timeline' doesn't exist on type 'PullRequest' #2481

jcansdale opened this issue Mar 18, 2020 · 1 comment
Assignees
@jcansdale

Comments

@jcansdale
Copy link
Collaborator

@jcansdale jcansdale commented Mar 18, 2020 •
edited

Reported by @parto:

@jcansdale it has another problem though when trying to open a PR:

Screen Shot 2020-03-17 at 12 59 52 PM

Notes

Here is the problem code:

VisualStudio/src/GitHub.InlineReviews/Services/PullRequestSessionService.cs

Line 387 in f3f8dee

Timeline = pr.Timeline(null, null, null, null, null).AllPages().Select(item => item.Switch<object>(when =>

See discussion here:
https://github.slack.com/archives/C44NVGUBB/p1584477659296100

@xuorig said:

We're going to be reverting that change for now while we investigate who got affected. But the field will go away soon again!

@nplasterer said:

the new timelineItems allows you to filter for just the events that you want
so you can say give me just the pr comments for the timeline

timelineItems(first: 20, itemTypes: [ISSUE_COMMENT])

I'll let people know when it has been changed to use timelineItems!
@jcansdale jcansdale self-assigned this Mar 18, 2020
@jcansdale jcansdale mentioned this issue Mar 18, 2020
Merged
4 of 4 tasks complete
@brvaland
Copy link

@brvaland brvaland commented May 1, 2020 •
edited

I have updated to latest version (2.11.96.24460) and getting know getting an error Field 'timelineItems' doesn't exist on type 'PullRequest'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcansdale jcansdale

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Use PullRequest.timelineItems instead of PullRequest.timeline
2 participants
@brvaland @jcansdale
You can’t perform that action at this time.