Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub Enterprise over http unable to adding review comment #2224
Comments
|
Hi @pmunin, Sorry about the delay getting back to you! I've been doing some investigation as it isn't obvious why it would be doing this. We should be preserving the HTTP or HTTPS protocol of the host. Could you try using the |
|
Just tried your advice, opened/cloned github repo from file/Open menu - same story, opens PR, and shows changes, but fails to add any comments to it. Just try this action on a local github server where HTTPS is unavailable (only HTTP) |
|
Thanks for letting me know. This is strange because the open/clone dialog uses GitHub v4/GraphQL API. I thought initially that the GitHub v4/GraphQL API might always be using HTTPS. I'm wondering if the issue might be the version of GitHub Enterprise you're using rather than HTTPS? Do you know which version you have installed? |
|
It says |
|
I am able to reproduce this issue using Enterprise 2.1.3 over http. |
|
Hi @pmunin, We're hoping this issue is fixed in #2305. Could you try installing the VSIX from the following location and let me know if that resolves the issue If you could comment on #2305, that would be great. |
|
Just tested, works now! |
Versions
What happened
I have github for enterprise intranet server deployed. There server only supports http connection (HTTP://github.{mycompany}.com). When works fine, until I try to add a comment for PR, it shows "An error occurred while sending the request". In Fiddler I can see, that it tries to send requests to HTTPS:443 tunnel, even though all other requests work fine and go through HTTP:80, including showing list of available PRs and shows existing comments fine.
Steps to Reproduce
Steps to reproduce the behavior:
Expected behavior
Successfully add request
Screenshots