Skip to content

/ VisualStudio

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standalone code review comment body duplicated. #2170

Closed
grokys opened this issue Jan 10, 2019 · 0 comments
Closed

Standalone code review comment body duplicated. #2170

grokys opened this issue Jan 10, 2019 · 0 comments
Assignees
@grokys
Labels
bug
Milestone
2.7.0

Comments

@grokys
Copy link
Contributor

@grokys grokys commented Jan 10, 2019

Versions

  • GitHub Extension for Visual Studio version: >2.6.0
  • Visual Studio version: All

What happened

When leaving a standalone PR review comment, the comment body is duplicated in the review body:

image

This is because we're sending the body twice here: https://github.com/github/VisualStudio/blame/4905769b54843fb81290846f04f829a3b357f66a/src/GitHub.InlineReviews/Services/PullRequestSessionService.cs#L652
@grokys grokys added the bug label Jan 10, 2019
@grokys grokys self-assigned this Jan 10, 2019
grokys added a commit that referenced this issue Jan 10, 2019
@grokys
Don't send duplicate comment body.
Loading status checks…
46fb5b5 
When adding a PR review comment, don't send the `body` twice, as it causes the body to be repeated in the comment itself and the containing review.

Fixes #2170
@grokys grokys mentioned this issue Jan 10, 2019
Merged
@jcansdale jcansdale added this to Done in BUGS via automation Jan 10, 2019
@meaghanlewis meaghanlewis added this to the 2.6.3 milestone Jan 11, 2019
@meaghanlewis meaghanlewis removed this from Done in BUGS Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grokys grokys

Labels
bug
Projects
None yet
Milestone
  2.7.0
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@grokys @meaghanlewis
You can’t perform that action at this time.