➜
This issue tracker will soon become read-only and move to GitHub.
For a smoother transition, remember to
log in and link your GitHub username to your profile.
For more information,
see this post about the migration.
Created on 2020-06-19 15:18 by nnemkin, last changed 2020-06-24 16:47 by miss-islington. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 20985 | merged | nnemkin, 2020-06-19 15:22 | |
| PR 21122 | merged | miss-islington, 2020-06-24 16:27 | |
| PR 21123 | merged | miss-islington, 2020-06-24 16:28 | |
| Messages (4) | |||
|---|---|---|---|
| msg371888 - (view) | Author: Nikita Nemkin (nnemkin) * | Date: 2020-06-19 15:18 | |
In absence of explicit declaration, resource compiler uses system
codepage. When this codepage is DBCS or UTF-8, Python's copyright
string is corrupted, because it contains copyright sign encoded
as \xA9.
The fix is to explicitly declare codepage 1252.
Another possible fix is to use codepage 65001, but that will require replacing \xA9 with an actual ©, because it seems impossible to escape unicode characters in VersionInfo strings.
|
|||
| msg372257 - (view) | Author: Steve Dower (steve.dower) *  |
Date: 2020-06-24 16:27 | |
New changeset 33b79b11b891adea5a916df8e3779505b37aabe7 by Nikita Nemkin in branch 'master': bpo-41038: Fix non-ASCII string corruption in Win32 resource files (GH-20985) https://github.com/python/cpython/commit/33b79b11b891adea5a916df8e3779505b37aabe7 |
|||
| msg372258 - (view) | Author: miss-islington (miss-islington) | Date: 2020-06-24 16:42 | |
New changeset fb4a6241054ad6b7f24d1b32af6827e02936d568 by Miss Islington (bot) in branch '3.8': bpo-41038: Fix non-ASCII string corruption in Win32 resource files (GH-20985) https://github.com/python/cpython/commit/fb4a6241054ad6b7f24d1b32af6827e02936d568 |
|||
| msg372263 - (view) | Author: miss-islington (miss-islington) | Date: 2020-06-24 16:47 | |
New changeset 153e20e087577553ad92a4c802c71d96244e508e by Miss Islington (bot) in branch '3.9': bpo-41038: Fix non-ASCII string corruption in Win32 resource files (GH-20985) https://github.com/python/cpython/commit/153e20e087577553ad92a4c802c71d96244e508e |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2020-06-24 16:47:48 | miss-islington | set | messages: + msg372263 |
| 2020-06-24 16:42:59 | miss-islington | set | messages: + msg372258 |
| 2020-06-24 16:29:08 | steve.dower | set | status: open -> closed assignee: steve.dower resolution: fixed stage: patch review -> resolved |
| 2020-06-24 16:28:02 | miss-islington | set | pull_requests: + pull_request20286 |
| 2020-06-24 16:27:55 | miss-islington | set | nosy:
+ miss-islington pull_requests: + pull_request20285 |
| 2020-06-24 16:27:52 | steve.dower | set | messages: + msg372257 |
| 2020-06-19 15:22:22 | nnemkin | set | keywords:
+ patch stage: patch review pull_requests: + pull_request20159 |
| 2020-06-19 15:18:28 | nnemkin | create | |