docs: added missing square braket#34414
docs: added missing square braket#34414RabbitHols wants to merge 2 commits intoangular:masterfrom RabbitHols:fix-missing-square-brackets
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. 鈩癸笍 Googlers: Go here for more info. |
|
@googlebot I fixed it. |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the 鈩癸笍 Googlers: Go here for more info. |
|
@googlebot I consent |
|
CLAs look good, thanks! 鈩癸笍 Googlers: Go here for more info. |
|
This is great, thank you, @RabbitHols! Could you rebase to see if we could get the tests to pass? I don't think it's anything in your PR. These are my notes on my own workflow for rebasing. If you need assistance with it, please tag me. 馃尯 |
|
Hi @RabbitHols, thanks for creating this PR. The change looks good, but as Kapunahele mentioned above, the PR should be rebased on top of the latest master to rerun the CI. Please let us know if you have a chance to do that. Thank you. |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the 鈩癸笍 Googlers: Go here for more info. |
|
Actually I realised that #37262 is going to completely remove this section, and since this PR author has not signed CLA, there is no point in continuing with this PR. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #34413
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Issue Number: 34413
#34413
Does this PR introduce a breaking change?
Other information