Skip to content

docs: added missing square braket#34414

Closed
RabbitHols wants to merge 2 commits intoangular:masterfrom
RabbitHols:fix-missing-square-brackets
Closed

docs: added missing square braket#34414
RabbitHols wants to merge 2 commits intoangular:masterfrom
RabbitHols:fix-missing-square-brackets

Conversation

@RabbitHols
Copy link
Copy Markdown

Fixes #34413

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Issue Number: 34413
#34413

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@RabbitHols RabbitHols requested a review from a team December 14, 2019 21:26
@googlebot
Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

鈩癸笍 Googlers: Go here for more info.

@RabbitHols
Copy link
Copy Markdown
Author

@googlebot I fixed it.

@googlebot
Copy link
Copy Markdown

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

鈩癸笍 Googlers: Go here for more info.

@Dirado
Copy link
Copy Markdown

Dirado commented Dec 14, 2019

@googlebot I consent

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

鈩癸笍 Googlers: Go here for more info.

@kapunahelewong
Copy link
Copy Markdown
Contributor

This is great, thank you, @RabbitHols! Could you rebase to see if we could get the tests to pass? I don't think it's anything in your PR. These are my notes on my own workflow for rebasing. If you need assistance with it, please tag me. 馃尯

@kapunahelewong kapunahelewong added the target: patch This PR is targeted for the next patch release label Dec 17, 2019
@AndrewKushnir AndrewKushnir added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Nov 24, 2020
@pullapprove pullapprove bot requested a review from crisbeto November 24, 2020 05:02
@AndrewKushnir
Copy link
Copy Markdown
Contributor

Hi @RabbitHols, thanks for creating this PR. The change looks good, but as Kapunahele mentioned above, the PR should be rebased on top of the latest master to rerun the CI. Please let us know if you have a chance to do that. Thank you.

@google-cla
Copy link
Copy Markdown

google-cla bot commented Dec 9, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

鈩癸笍 Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Dec 9, 2020
@petebacondarwin
Copy link
Copy Markdown
Contributor

Actually I realised that #37262 is going to completely remove this section, and since this PR author has not signed CLA, there is no point in continuing with this PR.

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews cla: no effort1: hours risk: low target: patch This PR is targeted for the next patch release type: bug/fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add missing square brackets

6 participants