Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deb and rpm metadata is incomplete #202

Open
pshem opened this issue Jun 17, 2019 · 3 comments
Open

deb and rpm metadata is incomplete #202

pshem opened this issue Jun 17, 2019 · 3 comments

Comments

@pshem
Copy link

@pshem pshem commented Jun 17, 2019

Describe the bug
codium's apt and rpm packages, as built by the recommended repository, are missing some metadata that differentiates codium from VS Code, such as the license and the project url.

Please confirm that this problem is VSCodium-specific

  • This bug doesn't happen if I use Microsoft's Visual Studio Code. It only happens in VSCodium.

This is not an issue in VS Code, because it affects things that differentiate codium from code.

Please confirm that the issue/resolution isn't already documented

To Reproduce
View the package metadata in a graphical package manager, such as Discover and from the commandline(apt show and the dnf equivalent).

Actual behaviour
For the deb package, as seen from Discover(screenshot in screenshots):

  • the license is unknown,
  • the homepage is that of code,
  • there is no logo,
  • the description talks about VS Code.

For the rpm package:

  • the license is correctly set to MIT,
  • the url points to VS Code
  • the description talks about VS Code,
  • no idea on the status of the logo.

Expected behavior
The license for both packages should be shown as MIT, the URL should be changed to this repository, the description should explain the difference between the two distributions, and the logo should be displayed in graphical package managers.

Screenshots
apt metadata in Discover

Desktop (please complete the following information):

  • OS: Kubuntu 19.04
  • Architecture amd64
  • Version 1.35.1-1560422401

Additional context
I have first reported the problem to the deb repository maintainer(@paulcarroty) at https://gitlab.com/paulcarroty/vscodium-deb-rpm-repo/issues/15 and been told this is an upstream issue that can only be solved in the vscodium repository.

@pshem pshem added the bug label Jun 17, 2019
@stripedpajamas
Copy link
Member

@stripedpajamas stripedpajamas commented Jun 19, 2019

Thanks for reporting this @pshem ! Would definitely like to clean this up. From what I can tell, the source of the information in the packages comes from these files:

It should be that we can slightly adjust these files pre-build.

@stripedpajamas
Copy link
Member

@stripedpajamas stripedpajamas commented Aug 9, 2019

As per #236, we need to make sure the MIT license is reflected properly in deb/rpm.

@paulcarroty
Copy link
Contributor

@paulcarroty paulcarroty commented Aug 10, 2019

@stripedpajamas can we add code.appdata.xml, debian/control.template, code.spec.template to vscodium repository? Writing tons of regexps to fix this issue seems unproductive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@paulcarroty @stripedpajamas @pshem and others
You can’t perform that action at this time.