➜

This issue tracker will soon become read-only and move to GitHub.
For a smoother transition, remember to log in and link your GitHub username to your profile.
For more information, see this post about the migration.

classification
Title: _PyDict_GetItemIdWithError() should call _PyDict_GetItem_KnownHash()
Type: performance Stage: resolved
Components: Interpreter Core Versions: Python 3.9
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: methane, scoder
Priority: low Keywords: easy (C), patch

Created on 2020-05-09 09:47 by scoder, last changed 2020-05-11 04:07 by scoder. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 20018 merged scoder, 2020-05-09 17:54
Messages (2)
msg368506 - (view) Author: Stefan Behnel (scoder) * (Python committer) Date: 2020-05-09 09:47 
_PyDict_GetItemIdWithError() looks up interned strings, which always have their hash value initialised. It can call _PyDict_GetItem_KnownHash() directly.
msg368604 - (view) Author: Stefan Behnel (scoder) * (Python committer) Date: 2020-05-11 04:04 
New changeset 6067d4bc3ce5ff4cfa5b47ceecc84a3941bc031c by scoder in branch 'master':
bpo-40575: Avoid unnecessary overhead in _PyDict_GetItemIdWithError() (GH-20018)
https://github.com/python/cpython/commit/6067d4bc3ce5ff4cfa5b47ceecc84a3941bc031c
History
Date User Action Args
2020-05-11 04:07:28scodersetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2020-05-11 04:04:38scodersetmessages: + msg368604
2020-05-09 17:54:39scodersetkeywords: + patch
stage: needs patch -> patch review
pull_requests: + pull_request19329
2020-05-09 11:39:39methanesetnosy: + methane
2020-05-09 09:51:41scodersetkeywords: + easy (C)
components: + Interpreter Core
2020-05-09 09:47:09scodercreate