bpo-40334: Fix test_peg_parser to actually use the old parser #19778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that the default parser is the new PEG parser, ast.parse uses it, which means that we don't actually test something in test_peg_parser. This PR introduces a new kwarg `oldparser` for `_peg_parser.parse_string` for specifying that a string needs to be parsed with the old parser. This kwarg is used in the tests to actually compare the ASTs the new parser generates with those generated by the old parser. Closes we-like-parsers/cpyhton#93.
pablogsal
approved these changes
Apr 28, 2020
|
Closing and opening to re-trigger the CI |
|
@pablogsal Can we merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Now that the default parser is the new PEG parser, ast.parse uses
it, which means that we don't actually test something in
test_peg_parser. This PR introduces a new kwarg
oldparserfor_peg_parser.parse_stringfor specifying that a string needs tobe parsed with the old parser. This kwarg is used in the tests to
actually compare the ASTs the new parser generates with those
generated by the old parser.
Closes we-like-parsers/cpyhton#93.
https://bugs.python.org/issue40334