Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'exception happened' to 'exception occurred' in two places #19767

Merged
merged 1 commit into from May 1, 2020

Conversation

@doersino
Copy link
Contributor

@doersino doersino commented Apr 28, 2020

Justification: The phrase "Exception happened" occurs twice in the code base, while "Exception occurred" occurs 30 times.

Since this is really only a cosmetic change akin to a typo fix, I didn't file an issue.

Copy link
Member

@gvanrossum gvanrossum left a comment

Thanks, I like this consistency.

@gvanrossum gvanrossum merged commit 8bcfd31 into python:master May 1, 2020
9 checks passed
9 checks passed
Docs
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200428.39 succeeded
Details
bedevere/issue-number Issue report skipped
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 1, 2020

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants