Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[3.8] bpo-35766: compile(): rename feature_version parameter (GH-13994) #14001
Conversation
bedevere-bot
added
the
skip news
label
Jun 12, 2019
the-knights-who-say-ni
added
the
CLA signed
label
Jun 12, 2019
bedevere-bot
added
the
awaiting core review
label
Jun 12, 2019
vstinner
merged commit b2fd32b
into
python:3.8
Jun 12, 2019
6 checks passed
bedevere/maintenance-branch-pr
Valid maintenance branch PR title.
bedevere/news
"skip news" label found
vstinner
deleted the
vstinner:compile_feature_version38
branch
Jun 12, 2019
bedevere-bot
removed
the
awaiting core review
label
Jun 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
vstinner commentedJun 12, 2019
•
edited by bedevere-bot
Rename compile() feature_version parameter to _feature_version and
convert it to a keyword-only parameter.
Update also test_type_comments to pass feature_version as a tuple.
(cherry picked from commit efdf6ca)
https://bugs.python.org/issue35766