Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 36 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesbpo-35766: Whats new in the ast and typing modules #13984
Conversation
gvanrossum
added some commits
Jun 11, 2019
gvanrossum
requested a review
from ilevkivskyi
Jun 11, 2019
the-knights-who-say-ni
added
the
CLA signed
label
Jun 11, 2019
bedevere-bot
added
type-documentation
awaiting core review
labels
Jun 11, 2019
gvanrossum
added
needs backport to 3.8
skip news
labels
Jun 11, 2019
gvanrossum
requested a review
from vstinner
Jun 11, 2019
vstinner
approved these changes
Jun 11, 2019
|
LGTM. I looked for "3.8" in https://docs.python.org/dev/library/ast.html and https://docs.python.org/dev/library/typing.html and it seems like all changes are documented. |
bedevere-bot
added
awaiting merge
and removed
awaiting core review
labels
Jun 11, 2019
gvanrossum
merged commit 9b33ce4
into
python:master
Jun 11, 2019
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Jun 11, 2019
|
@gvanrossum: Please replace |
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Jun 11, 2019
|
Thanks @gvanrossum for the PR |
bedevere-bot
removed
the
awaiting merge
label
Jun 11, 2019
gvanrossum
deleted the
gvanrossum:whats-new-ast-typing
branch
Jun 11, 2019
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Jun 11, 2019
|
GH-13987 is a backport of this pull request to the 3.8 branch. |
bedevere-bot
removed
the
needs backport to 3.8
label
Jun 11, 2019
miss-islington
added a commit
to miss-islington/cpython
that referenced
this pull request
Jun 11, 2019
miss-islington
added a commit
that referenced
this pull request
Jun 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
gvanrossum commentedJun 11, 2019
•
edited by bedevere-bot
Lumping these together because they both come from the static type checking world.
https://bugs.python.org/issue35766