Skip to content

Updated Python Extension description to add Jupyter Notebook support#8545

Merged
DonJayamanne merged 1 commit intomasterfrom
jemew/update-description
Dec 10, 2019
Merged

Updated Python Extension description to add Jupyter Notebook support#8545
DonJayamanne merged 1 commit intomasterfrom
jemew/update-description

Conversation

@jmew
Copy link
Copy Markdown

@jmew jmew commented Nov 12, 2019

For #

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@jmew jmew force-pushed the jemew/update-description branch from 30990a8 to a7193ac Compare November 12, 2019 21:47
@jmew jmew added the no-changelog No news entry required label Nov 12, 2019
DonJayamanne
DonJayamanne reviewed Nov 12, 2019
View reviewed changes
Comment thread README.md Outdated
@jmew jmew force-pushed the jemew/update-description branch from a7193ac to d487d53 Compare November 12, 2019 21:53
@jmew jmew force-pushed the jemew/update-description branch from d487d53 to 451d20f Compare November 12, 2019 22:03
@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 12, 2019 •
edited
Loading

Codecov Report

Merging #8545 into master will increase coverage by 0.5%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #8545     +/-   ##
=========================================
+ Coverage    58.7%   59.21%   +0.5%     
=========================================
  Files         511      521     +10     
  Lines       23306    25020   +1714     
  Branches     3824     4178    +354     
=========================================
+ Hits        13682    14815   +1133     
- Misses       8705     9261    +556     
- Partials      919      944     +25
Impacted Files Coverage Δ
...client/datascience/jupyter/jupyterServerFactory.ts 21.15% <0%> (-11.11%) ⬇️
...datascience/jupyter/liveshare/hostJupyterServer.ts 11.4% <0%> (-4.65%) ⬇️
...tascience/jupyter/liveshare/hostJupyterNotebook.ts 7.56% <0%> (-2.84%) ⬇️
src/client/datascience/jupyter/jupyterNotebook.ts 6.22% <0%> (-0.04%) ⬇️
...t/datascience/jupyter/jupyterDataRateLimitError.ts 100% <0%> (ø) ⬆️
src/client/formatters/serviceRegistry.ts 100% <0%> (ø) ⬆️
...lient/datascience/jupyter/jupyterSelfCertsError.ts 100% <0%> (ø) ⬆️
src/client/providers/terminalProvider.ts 100% <0%> (ø) ⬆️
src/client/debugger/extension/serviceRegistry.ts 100% <0%> (ø) ⬆️
...ience/jupyter/jupyterDebuggerRemoteNotSupported.ts 100% <0%> (ø) ⬆️
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8874744...451d20f. Read the comment docs.

@DonJayamanne DonJayamanne reopened this Nov 14, 2019
@jmew jmew closed this Nov 18, 2019
@jmew jmew reopened this Nov 18, 2019
@DonJayamanne DonJayamanne merged commit b96e7a3 into master Dec 10, 2019
@lock lock Bot locked as resolved and limited conversation to collaborators Dec 17, 2019
@DonJayamanne DonJayamanne deleted the jemew/update-description branch February 24, 2020 17:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DonJayamanne DonJayamanne DonJayamanne approved these changes

@rchiodo rchiodo rchiodo approved these changes

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jmew @codecov-io @DonJayamanne @rchiodo