Skip to content

/ vscode-python Public

forked from DonJayamanne/pythonVSCode
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add command translation for Farsi/Persian #8092

Merged
merged 5 commits into from Oct 26, 2019
Merged

Add command translation for Farsi/Persian #8092

merged 5 commits into from Oct 26, 2019

Conversation

@Nikronic
Copy link

@Nikronic Nikronic commented Oct 18, 2019 •
edited

For #7931

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.
Nikronic added 2 commits Oct 17, 2019
@Nikronic
add command translations for Farsi
6e008b3
@Nikronic
using half-space and some word refinement
ced3eb5
@msftclas
Copy link

@msftclas msftclas commented Oct 18, 2019 •
edited

CLA assistant check
All CLA requirements met.

@Nikronic
add news entry
a3f224a
@codecov-io
Copy link

@codecov-io codecov-io commented Oct 18, 2019 •
edited

Codecov Report

Merging #8092 into master will decrease coverage by 0.68%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8092      +/-   ##
==========================================
- Coverage   59.26%   58.57%   -0.69%     
==========================================
  Files         499      505       +6     
  Lines       22411    24066    +1655     
  Branches     3598     4042     +444     
==========================================
+ Hits        13281    14096     +815     
- Misses       8301     9084     +783     
- Partials      829      886      +57
Impacted Files Coverage Δ
...ascience/interactive-ipynb/nativeEditorProvider.ts 51.51% <0%> (-7%) ⬇️
src/client/datascience/constants.ts 100% <0%> (ø) ⬆️
...ience/interactive-common/interactiveWindowTypes.ts 100% <0%> (ø) ⬆️
src/client/datascience/types.ts 100% <0%> (ø) ⬆️
src/client/common/types.ts 100% <0%> (ø) ⬆️
src/client/datascience/statusProvider.ts 9.43% <0%> (ø)
...ent/datascience/data-viewing/dataViewerProvider.ts 27.77% <0%> (ø)
src/client/datascience/jupyter/jupyterDebugger.ts 10.05% <0%> (ø)
src/client/datascience/themeFinder.ts 7.21% <0%> (ø)
src/datascience-ui/react-common/arePathsSame.ts 0% <0%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3db7b2f...21b3dea. Read the comment docs.

@karthiknadig karthiknadig requested a review from luabud Oct 18, 2019
@karthiknadig
Copy link
Member

@karthiknadig karthiknadig commented Oct 22, 2019

@Nikronic Thank you for the translation. For Django, Flask, and Pyramid we want keep them in Latin script. Generally we don't translate product names.

@Nikronic
Copy link
Author

@Nikronic Nikronic commented Oct 22, 2019

@karthiknadig you right. Actually I was in a dilemma that I should follow English convention or Farsi community's. I will resolve it soon.
Thank you

@Nikronic
using Latin script for poduct names
f1c7a25
karthiknadig
karthiknadig reviewed Oct 25, 2019
View changes
README.md Outdated Show resolved Hide resolved
@Nikronic @karthiknadig
Update README.md
21b3dea 
Co-Authored-By: Karthik Nadig <kanadig@microsoft.com>
@karthiknadig karthiknadig merged commit c831ce6 into microsoft:master Oct 26, 2019
20 checks passed
@lock lock bot locked as resolved and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@karthiknadig karthiknadig

@luabud luabud

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Nikronic @msftclas @codecov-io @karthiknadig @kimadeline