Skip to content

Update ppa type definitions#11067

Merged
greazer merged 4 commits intomasterfrom
ds/greazer/update-ppa-types
Apr 10, 2020
Merged

Update ppa type definitions#11067
greazer merged 4 commits intomasterfrom
ds/greazer/update-ppa-types

Conversation

@greazer
Copy link
Copy Markdown
Member

@greazer greazer commented Apr 10, 2020

There was an issue for this, but haven't been able to load it.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@greazer greazer added the no-changelog No news entry required label Apr 10, 2020
@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 10, 2020 •
edited
Loading

Codecov Report

Merging #11067 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11067      +/-   ##
==========================================
- Coverage   61.27%   61.25%   -0.03%     
==========================================
  Files         593      593              
  Lines       32492    32492              
  Branches     4593     4593              
==========================================
- Hits        19910    19903       -7     
- Misses      11580    11585       +5     
- Partials     1002     1004       +2
Impacted Files Coverage Δ
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
...client/datascience/kernel-launcher/kernelFinder.ts 75.70% <0.00%> (-0.94%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d96be50...7e02d66. Read the comment docs.

@IanMatthewHuff
Copy link
Copy Markdown
Member

IanMatthewHuff commented Apr 10, 2020

@greazer . Hey Jim. What's the context on this change? New drop from Rob?

rchiodo
rchiodo approved these changes Apr 10, 2020
View reviewed changes
Copy link
Copy Markdown

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@greazer
Copy link
Copy Markdown
Member Author

greazer commented Apr 10, 2020

@greazer . Hey Jim. What's the context on this change? New drop from Rob?

There's two aspects. One is that yes, we have a new drop from Rob. I didn't really HAVE to do this based on what he changed and the API's we're currently using, but I was debugging an issue that I thought may have been related to his changes. The second is that Rich had entered a bug a little time ago asking whether we need to have as many files in the ppa types folder as we did. We don't. I couldn't find that issue. It's here somewhere.

@greazer greazer merged commit 4eb8cc8 into master Apr 10, 2020
@greazer greazer deleted the ds/greazer/update-ppa-types branch April 10, 2020 17:23
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 10, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@lock lock Bot locked as resolved and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rchiodo rchiodo rchiodo approved these changes

@IanMatthewHuff IanMatthewHuff Awaiting requested review from IanMatthewHuff

@DonJayamanne DonJayamanne Awaiting requested review from DonJayamanne

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@greazer @codecov-io @IanMatthewHuff @rchiodo