Skip to content

/ vscode-python Public

forked from DonJayamanne/pythonVSCode
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added command translations for hindi #10711

Merged
merged 12 commits into from Mar 24, 2020
Merged

Added command translations for hindi #10711

merged 12 commits into from Mar 24, 2020

Conversation

@abhirampai
Copy link

@abhirampai abhirampai commented Mar 23, 2020 •
edited

For #

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.
@abhirampai
Create package.nls.hindi.json
6b28029
@codecov-io
Copy link

@codecov-io codecov-io commented Mar 23, 2020 •
edited

Codecov Report

Merging #10711 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10711      +/-   ##
==========================================
- Coverage   60.63%   60.62%   -0.02%     
==========================================
  Files         583      583              
  Lines       31557    31557              
  Branches     4488     4488              
==========================================
- Hits        19136    19130       -6     
- Misses      11449    11453       +4     
- Partials      972      974       +2
Impacted Files Coverage Δ
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68d7acb...dc0b865. Read the comment docs.

DonJayamanne
DonJayamanne reviewed Mar 23, 2020
View changes
package.nls.hindi.json
"python.command.python.goToPythonObject.title": "पायथन ऑब्जेक्ट पर जाएं",
"python.command.python.setLinter.title": "लिंटर चुनें",
"python.command.python.enableLinting.title": "Linting सक्षम करें",
"python.command.python.runLinting.title": "Linting चलाएं",
Copy link

@DonJayamanne DonJayamanne Mar 23, 2020

Thanks for the PR.

Curios, here we use Linting in English, however in line 21 we use Hindi for the word Linter. I'd prefer to be consistent, either Hindi or English for linter.

@karrtikr @karthiknadig /cc. (Not my first language hence please review)

Copy link
Member

@karthiknadig karthiknadig Mar 23, 2020

Agreed, it should be consistent either hind or english.

Copy link
Author

@abhirampai abhirampai Mar 24, 2020

I think English would be Better

karrtikr
karrtikr reviewed Mar 23, 2020
View changes
package.nls.hindi.json Outdated Show resolved Hide resolved
karthiknadig
karthiknadig reviewed Mar 23, 2020
View changes
package.nls.hindi.json Outdated Show resolved Hide resolved
karthiknadig
karthiknadig reviewed Mar 23, 2020
View changes
package.nls.hindi.json Outdated Show resolved Hide resolved
karthiknadig
karthiknadig reviewed Mar 23, 2020
View changes
package.nls.hindi.json Outdated Show resolved Hide resolved
karthiknadig
karthiknadig reviewed Mar 23, 2020
View changes
package.nls.hindi.json Outdated Show resolved Hide resolved
karthiknadig
karthiknadig reviewed Mar 23, 2020
View changes
package.nls.hindi.json Outdated Show resolved Hide resolved
karthiknadig
karthiknadig reviewed Mar 23, 2020
View changes
package.nls.hindi.json Outdated Show resolved Hide resolved
karthiknadig
karthiknadig reviewed Mar 23, 2020
View changes
package.nls.hindi.json Outdated Show resolved Hide resolved
karthiknadig
karthiknadig reviewed Mar 23, 2020
View changes
package.nls.hindi.json Outdated Show resolved Hide resolved
karthiknadig
karthiknadig requested changes Mar 23, 2020
View changes
Copy link
Member

@karthiknadig karthiknadig left a comment

Thanks for the translation. I understand English to Hindi in many cases is hard. I have made some suggestions, please update. Don;t forget to add a news item.

abhirampai and others added 11 commits Mar 24, 2020
@abhirampai @karthiknadig
Update package.nls.hindi.json
0cef0f0 
Co-Authored-By: Karthik Nadig <kanadig@microsoft.com>
@abhirampai @karthiknadig
Update package.nls.hindi.json
bfb54df 
Co-Authored-By: Karthik Nadig <kanadig@microsoft.com>
@abhirampai @karthiknadig
Update package.nls.hindi.json
29247b9 
Co-Authored-By: Karthik Nadig <kanadig@microsoft.com>
@abhirampai @karthiknadig
Update package.nls.hindi.json
74cffc5 
Co-Authored-By: Karthik Nadig <kanadig@microsoft.com>
@abhirampai @karthiknadig
Update package.nls.hindi.json
9c9557a 
Co-Authored-By: Karthik Nadig <kanadig@microsoft.com>
@abhirampai @karthiknadig
Update package.nls.hindi.json
12b98be 
Co-Authored-By: Karthik Nadig <kanadig@microsoft.com>
@abhirampai @karthiknadig
Update package.nls.hindi.json
b8f86b9 
Co-Authored-By: Karthik Nadig <kanadig@microsoft.com>
@abhirampai @karthiknadig
Update package.nls.hindi.json
ee69a60 
Co-Authored-By: Karthik Nadig <kanadig@microsoft.com>
@abhirampai
Update package.nls.hindi.json
784953e
@abhirampai
Update package.nls.hindi.json
17517b3
@abhirampai
Create 10711.md
dc0b865
@sonarcloud
Copy link

@sonarcloud sonarcloud bot commented Mar 24, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@abhirampai
Copy link
Author

@abhirampai abhirampai commented Mar 24, 2020

Thanks for the translation. I understand English to Hindi in many cases is hard. I have made some suggestions, please update. Don;t forget to add a news item.

ok done.

@karrtikr karrtikr merged commit c4658f9 into microsoft:master Mar 24, 2020
18 checks passed
@lock lock bot locked as resolved and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DonJayamanne DonJayamanne

@karthiknadig karthiknadig

@karrtikr karrtikr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@abhirampai @codecov-io @DonJayamanne @karthiknadig @karrtikr