Skip to content

/ devguide

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark python 2.7 as dead #560

Merged
merged 3 commits into from Jan 29, 2020
Merged

Mark python 2.7 as dead #560

merged 3 commits into from Jan 29, 2020

Conversation

@RDIL
Copy link
Contributor

@RDIL RDIL commented Jan 14, 2020

No description provided.

@RDIL
Mark python 2.7 as dead
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
55d6141
@terryjreedy terryjreedy requested a review from benjaminp Jan 14, 2020
@benjaminp
Copy link
Contributor

@benjaminp benjaminp commented Jan 15, 2020

This seems fine, though it'd be nice to have the CLA signed.
@RDIL
Copy link
Contributor Author

@RDIL RDIL commented Jan 15, 2020

Yeah, I actually signed it yesterday.
@RDIL
Copy link
Contributor Author

@RDIL RDIL commented Jan 15, 2020 •
edited by terryjreedy

My guess is that the secretary hasn't filed the CLA yet in the records.

TJR response: yes, one of us can try in another day.
@terryjreedy
terryjreedy requested changes Jan 15, 2020
View changes
Copy link
Member

@terryjreedy terryjreedy left a comment

Move 2.7 entry and add 'unsupported' entry.
index.rst Outdated Show resolved Hide resolved
index.rst Outdated Show resolved Hide resolved
@RDIL
Remove from table
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
10341ee
@RDIL RDIL requested a review from terryjreedy Jan 16, 2020
@jdufresne
Copy link
Contributor

@jdufresne jdufresne commented Jan 26, 2020

I think an entry should be added to the "End of life" section:

https://github.com/python/devguide/blob/master/devcycle.rst#end-of-life-branches
@RDIL
update devcycle
Loading status checks…
a02c365
@RDIL RDIL requested a review from zware Jan 27, 2020
@RDIL
Copy link
Contributor Author

@RDIL RDIL commented Jan 27, 2020

Done @jdufresne @terryjreedy
@terryjreedy
terryjreedy approved these changes Jan 28, 2020
View changes
Copy link
Member

@terryjreedy terryjreedy left a comment

Benjamin, do you want to do a final check of the revised PR?
@python python deleted a comment from the-knights-who-say-ni Jan 28, 2020
@benjaminp benjaminp merged commit c8c0f2b into python:master Jan 29, 2020
6 checks passed
6 checks passed
Header rules No header rules processed
Details
Pages changed 37 new files uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@RDIL RDIL deleted the RDIL:patch-1 branch Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy

@benjaminp benjaminp

@zware zware

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@RDIL @benjaminp @jdufresne @zware @terryjreedy @the-knights-who-say-ni
You can’t perform that action at this time.