Skip to content

/ devguide

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken urls and change the url of Coverity Model #223

Merged
merged 5 commits into from Aug 3, 2018
Merged

Fix broken urls and change the url of Coverity Model #223

merged 5 commits into from Aug 3, 2018

Conversation

@matrixise
Copy link
Member

@matrixise matrixise commented Jun 9, 2017

Fix #221
matrixise added 3 commits Jun 9, 2017
@matrixise
Fix the url to the buildbot and the latent buildslaves
e77634a
@matrixise
Fix the description for the mirrors of the mailing lists.
51837c7 
Unfortunately, the gmane.org service has stopped the web interface and
the RSS feeds. We can use the nntp protocol with a NNTP newreader.
@matrixise
Fix the url of the coverity model, use the url from the official CPython
Loading status checks…
d677fa5 
repository instead of the former Mercurial repository.
@matrixise matrixise requested review from zware Jun 12, 2017
@Mariatta
Mariatta approved these changes Jul 31, 2017
View changes
@Mariatta
Mariatta reviewed Jul 31, 2017
View changes
coverity.rst Outdated
@@ -150,4 +150,4 @@ Dakshesh Vyas <scan-admin@coverity.com>

.. _Coverity Connect: http://scan5.coverity.com:8080/

.. _coverity_model.c: https://hg.python.org/cpython/file/tip/Misc/coverity_model.c
.. _coverity_model.c: https://raw.githubusercontent.com/python/cpython/master/Misc/coverity_model.c

This comment has been minimized.

Sign in to view
@Mariatta

Mariatta Jul 31, 2017
Member

I think the url should be https://github.com/python/cpython/blob/master/Misc/coverity_model.c

This comment has been minimized.

Sign in to view
@tiran

tiran Jul 31, 2017
Member

+1

This comment has been minimized.

Sign in to view
@matrixise

matrixise Jul 31, 2018
Author Member

I have updated this url
@Mariatta
Mariatta requested changes Jul 31, 2017
View changes
Copy link
Member

@Mariatta Mariatta left a comment

There is a conflict, and the url to coverity_model.c should be changed.
@ezio-melotti
Copy link
Member

@ezio-melotti ezio-melotti commented Sep 5, 2017

This PR should be updated.
@willingc willingc mentioned this pull request Mar 19, 2018
Closed
@willingc
Copy link
Collaborator

@willingc willingc commented May 21, 2018

Hi @matrixise, Do you want to finish this up or would you prefer closing it? Either one is cool. Thanks.
@zware
zware requested changes May 23, 2018
View changes
buildslave.rst Outdated
@@ -196,7 +196,7 @@ Latent slaves
^^^^^^^^^^^^^

We also support running `latent buildslaves
<http://docs.buildbot.net/current/manual/cfg-buildslaves.html#latent-buildslaves>`_
<http://docs.buildbot.net/0.8.14/manual/cfg-buildslaves.html#latent-buildslaves>`_

This comment has been minimized.

Sign in to view
@zware

zware May 23, 2018
Member

We're now on current buildbot; this page has also been updated in the meanwhile.
matrixise added 2 commits Jul 31, 2018
@matrixise
Merge
d912a71
@matrixise
Fix the url of the coverity_model.c file
Loading status checks…
d7078e0
@matrixise
Copy link
Member Author

@matrixise matrixise commented Jul 31, 2018 •
edited

Hi @Mariatta and @willingc I am really so sorry, I didn't see the notification about this issue/pr. I just updated to the last version of the repo and updated the link for the coverity_model.c file.

When you have time for a review.

Thank you so much,
@zware
zware approved these changes Jul 31, 2018
View changes
@matrixise matrixise merged commit 420672f into python:master Aug 3, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiran tiran

@Mariatta Mariatta

@zware zware

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@matrixise @ezio-melotti @willingc @tiran @Mariatta @zware @the-knights-who-say-ni
You can’t perform that action at this time.