Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-38657: Clarify numeric padding behaviour in string formatting #17036

Merged
merged 5 commits into from Feb 21, 2020

Conversation

JamoBox
Copy link
Contributor

@JamoBox JamoBox commented Nov 3, 2019

Make the definition of the width more explicit that it includes any
extra signs added by other options.

https://bugs.python.org/issue38657

Automerge-Triggered-By: @Mariatta

Make the definition of the width more explicit that it includes any
extra signs added by other options.
@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Nov 3, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@JamoBox

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@brandtbucher
Copy link
Member

brandtbucher commented Nov 4, 2019

Thanks for your time @JamoBox, and welcome to CPython! 😎

I assume that you've seen the bot's message about the CLA?

Copy link
Member

@brandtbucher brandtbucher left a comment

I have one suggestion, but otherwise this looks good:

Doc/library/string.rst Outdated Show resolved Hide resolved
Co-Authored-By: Brandt Bucher <brandtbucher@gmail.com>
@JamoBox
Copy link
Contributor Author

JamoBox commented Nov 4, 2019

Thanks for your time @JamoBox, and welcome to CPython! 😎

I assume that you've seen the bot's message about the CLA?

I've signed the CLA, although it hasn't updated yet.

@JamoBox
Copy link
Contributor Author

JamoBox commented Nov 4, 2019

I have one suggestion, but otherwise this looks good:

Great, that works perfectly. I've added it in, thanks.

@brandtbucher
Copy link
Member

brandtbucher commented Nov 4, 2019

Great! Can you re-wrap the line, too?

Signed-off-by: Pete Wicken <petewicken@gmail.com>
Python/formatter_unicode.c Outdated Show resolved Hide resolved
JamoBox added 2 commits Nov 4, 2019
This reverts commit 4996e98.
Signed-off-by: Pete Wicken <petewicken@gmail.com>
Copy link
Sponsor Member

@Mariatta Mariatta left a comment

Thanks!

@miss-islington miss-islington merged commit 424e568 into python:master Feb 21, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Feb 21, 2020

Thanks @JamoBox for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒🤖

@bedevere-bot
Copy link

bedevere-bot commented Feb 21, 2020

GH-18587 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

bedevere-bot commented Feb 21, 2020

GH-18588 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 21, 2020
…thonGH-17036)

Make the definition of the width more explicit that it includes any
extra signs added by other options.

https://bugs.python.org/issue38657

Automerge-Triggered-By: @Mariatta
(cherry picked from commit 424e568)

Co-authored-by: Pete Wicken <2273100+JamoBox@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Feb 21, 2020
…-17036)

Make the definition of the width more explicit that it includes any
extra signs added by other options.

https://bugs.python.org/issue38657

Automerge-Triggered-By: @Mariatta
(cherry picked from commit 424e568)

Co-authored-by: Pete Wicken <2273100+JamoBox@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Feb 21, 2020
…-17036)

Make the definition of the width more explicit that it includes any
extra signs added by other options.

https://bugs.python.org/issue38657

Automerge-Triggered-By: @Mariatta
(cherry picked from commit 424e568)

Co-authored-by: Pete Wicken <2273100+JamoBox@users.noreply.github.com>
@brandtbucher
Copy link
Member

brandtbucher commented Feb 21, 2020

Congrats on your first CPython contribution @JamoBox! 🍾

Looking forward to seeing more from you in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir 🤖 automerge PR will be merged once it's been approved and all CI passed skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants