Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39185 Add the d[etailed] and q[uiet] verbosity levels for msbuild #17791

Merged
merged 3 commits into from Feb 5, 2020
Merged

bpo-39185 Add the d[etailed] and q[uiet] verbosity levels for msbuild #17791

merged 3 commits into from Feb 5, 2020

Conversation

@tonybaloney
Copy link
Contributor

tonybaloney commented Jan 2, 2020 •
edited by bedevere-bot

Add the d[etailed] and q[uiet] verbosity levels for msbuild as options in build.bat

https://bugs.python.org/issue39185
@tonybaloney
Add the d[etailed] and q[uiet] verbosity levels for msbuild as option…
Verified
This commit was signed with a verified signature.
tonybaloney Anthony Shaw
GPG key ID: A5B5836F7895863C Learn about signing commits
Loading status checks…
fd3f61c 
…s in build.bat
@tonybaloney tonybaloney requested a review from python/windows-team as a code owner Jan 2, 2020
@blurb-it
📜🤖 Added by blurb_it.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
cd14304
@zooba
zooba reviewed Jan 3, 2020
View changes
PCbuild/build.bat Outdated Show resolved Hide resolved
@tonybaloney
Add detailed summary to very verbose and no logo/console summart to q…
Loading status checks…
62e3910 
…uiet.
@tonybaloney

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

tonybaloney commented Jan 3, 2020

@zooba please re-review with the changes requested
@csabella csabella requested a review from zooba Jan 12, 2020
@zooba zooba merged commit 89ae20b into python:master Feb 5, 2020
9 checks passed
9 checks passed
Docs
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200103.28 succeeded
Details
bedevere/issue-number Issue number 39185 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Feb 5, 2020

Thanks @tonybaloney for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Feb 5, 2020

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.
miss-islington added a commit to miss-islington/cpython that referenced this pull request Feb 5, 2020
@tonybaloney @miss-islington
bpo-39185 Add the d[etailed] and q[uiet] verbosity levels for msbuild (…
f634911 
…pythonGH-17791)

(cherry picked from commit 89ae20b)

Co-authored-by: Anthony Shaw <anthony.p.shaw@gmail.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Feb 5, 2020

GH-18354 is a backport of this pull request to the 3.7 branch.
@miss-islington

This comment has been minimized.

Sign in to view
Copy link

miss-islington commented Feb 5, 2020

Thanks @tonybaloney for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
miss-islington added a commit to miss-islington/cpython that referenced this pull request Feb 5, 2020
@tonybaloney @miss-islington
bpo-39185 Add the d[etailed] and q[uiet] verbosity levels for msbuild (…
0dfbdfb 
…pythonGH-17791)

(cherry picked from commit 89ae20b)

Co-authored-by: Anthony Shaw <anthony.p.shaw@gmail.com>
@bedevere-bot

This comment has been minimized.

Sign in to view
Copy link

bedevere-bot commented Feb 5, 2020

GH-18355 is a backport of this pull request to the 3.8 branch.
miss-islington added a commit that referenced this pull request Feb 5, 2020
@miss-islington @tonybaloney
bpo-39185 Add the d[etailed] and q[uiet] verbosity levels for msbuild (…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6ba8dc6 
…GH-17791)

(cherry picked from commit 89ae20b)

Co-authored-by: Anthony Shaw <anthony.p.shaw@gmail.com>
miss-islington added a commit that referenced this pull request Feb 5, 2020
@miss-islington @tonybaloney
bpo-39185 Add the d[etailed] and q[uiet] verbosity levels for msbuild (…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6470a76 
…GH-17791)

(cherry picked from commit 89ae20b)

Co-authored-by: Anthony Shaw <anthony.p.shaw@gmail.com>
@tonybaloney tonybaloney deleted the tonybaloney:quiet_msbuild_flag branch Feb 5, 2020
opavlyuk pushed a commit to opavlyuk/cpython that referenced this pull request Feb 12, 2020
@tonybaloney opavliuk
bpo-39185 Add the d[etailed] and q[uiet] verbosity levels for msbuild (…
f3fd9df 
…pythonGH-17791)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zooba zooba

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@tonybaloney @miss-islington @bedevere-bot @zooba @the-knights-who-say-ni
You can’t perform that action at this time.