Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-39594: Fix typo in os.times documentation #18443

Merged
merged 1 commit into from Feb 10, 2020
Merged

bpo-39594: Fix typo in os.times documentation #18443

merged 1 commit into from Feb 10, 2020

Conversation

rogerhurwitz
Copy link
Contributor

@rogerhurwitz rogerhurwitz commented Feb 10, 2020 •
edited by miss-islington

There was an extra space in the url markup, causing the documentation not rendered properly.

https://bugs.python.org/issue39594

Automerge-Triggered-By: @Mariatta

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Feb 10, 2020
@Mariatta Mariatta changed the title bpo-39594: Fixed typo identified by issue submitter. bpo-39594: Fix typo in os.times documentation Feb 10, 2020
@Mariatta
Copy link
Sponsor Member

Mariatta commented Feb 10, 2020

Thanks for the PR. I think it looks good. For future, it really would be helpful to describe the change made in this pr instead of "fix issue reported by submitter". (I've changed your PR title and description).

@Mariatta Mariatta added needs backport to 3.7 needs backport to 3.8 🤖 automerge PR will be merged once it's been approved and all CI passed labels Feb 10, 2020
@miss-islington miss-islington merged commit 37c55b2 into python:master Feb 10, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Feb 10, 2020

Thanks @rogerhurwitz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Feb 10, 2020

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 10, 2020
@rogerhurwitz @miss-islington
bpo-39594: Fix typo in os.times documentation (pythonGH-18443)
b98a8a4 
There was an extra space in the url markup, causing the documentation not rendered properly.

https://bugs.python.org/issue39594
(cherry picked from commit 37c55b2)

Co-authored-by: Roger Hurwitz <rogerhurwitz@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Feb 10, 2020

GH-18444 is a backport of this pull request to the 3.7 branch.

@rogerhurwitz rogerhurwitz deleted the bpo-39594 branch Feb 10, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Feb 10, 2020

Thanks @rogerhurwitz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 10, 2020
@rogerhurwitz @miss-islington
bpo-39594: Fix typo in os.times documentation (pythonGH-18443)
3de9ba1 
There was an extra space in the url markup, causing the documentation not rendered properly.

https://bugs.python.org/issue39594
(cherry picked from commit 37c55b2)

Co-authored-by: Roger Hurwitz <rogerhurwitz@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Feb 10, 2020

GH-18447 is a backport of this pull request to the 3.8 branch.

@rogerhurwitz
Copy link
Contributor Author

rogerhurwitz commented Feb 10, 2020

Thanks for the feedback - will make the PR text more descriptive in the future.

miss-islington added a commit that referenced this pull request Feb 10, 2020
@miss-islington @rogerhurwitz
bpo-39594: Fix typo in os.times documentation (GH-18443)
a12effd 
There was an extra space in the url markup, causing the documentation not rendered properly.

https://bugs.python.org/issue39594
(cherry picked from commit 37c55b2)

Co-authored-by: Roger Hurwitz <rogerhurwitz@gmail.com>
miss-islington added a commit that referenced this pull request Feb 10, 2020
@miss-islington @rogerhurwitz
bpo-39594: Fix typo in os.times documentation (GH-18443)
4d43017 
There was an extra space in the url markup, causing the documentation not rendered properly.

https://bugs.python.org/issue39594
(cherry picked from commit 37c55b2)

Co-authored-by: Roger Hurwitz <rogerhurwitz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariatta Mariatta

Assignees
No one assigned
Labels
docs Documentation in the Doc dir 🤖 automerge PR will be merged once it's been approved and all CI passed skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rogerhurwitz @Mariatta @miss-islington @bedevere-bot @the-knights-who-say-ni