Skip to content

/ VisualStudio

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR Details compares wrong version after pull #901

Closed
grokys opened this issue Mar 2, 2017 · 0 comments
Closed

PR Details compares wrong version after pull #901

grokys opened this issue Mar 2, 2017 · 0 comments
Assignees
@grokys
Labels
bug

Comments

@grokys
Copy link
Contributor

@grokys grokys commented Mar 2, 2017

After a pull is carried out in the PR details view, comparing file contents show the diff from before the pull. Going back to the PR list and reopening the PR seems to fix it.
@grokys grokys added the bug label Mar 2, 2017
@grokys grokys self-assigned this Mar 2, 2017
grokys added a commit that referenced this issue Mar 2, 2017
@grokys
Compare IPullRequestModel by ref in setter.
Loading status checks…
14f0027 
PullRequestModel overrides Equals such that two PRs with the same number are
considered equal. This was causing the Model not to be updated on refresh: we need to use ReferenceEquals. Fixes #901
@grokys grokys mentioned this issue Mar 2, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grokys grokys

Labels
bug
Projects
None yet
Milestone
No milestone
1 participant
@grokys
You can’t perform that action at this time.