Skip to content

/ VisualStudio

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clone repo while cloning another repo #849

Closed
BOT-Man-JL opened this issue Feb 11, 2017 · 2 comments
Closed

Clone repo while cloning another repo #849

BOT-Man-JL opened this issue Feb 11, 2017 · 2 comments
Labels
bug
Projects
2.2.0.8

Comments

@BOT-Man-JL
Copy link

@BOT-Man-JL BOT-Man-JL commented Feb 11, 2017

  • GitHub Extension for Visual Studio version: 2.2.0.6
  • Visual Studio version: 14.0.25431.01 Update 3

Steps:

  • Clone an arbitrary repo from your repos on GitHub-Connect-Team Explorer
  • Clone another repo while cloning the previous one (the connection is soooooo sloooooow in China 😅 )

Current behavior:

  • The extension creates two folders for corresponding repos
  • The first repo is cloned successfully
  • The second repo is not cloned (the folder is left empty)
  • When trying again to clone the second repo, the extension will say that the folder is already existing (red !).

Expected behavior:

  • Disable clone link while another one is processing
  • Add the pending clone action into a queue

😉 Love this extension so much.
@grokys grokys added the bug label Feb 13, 2017
@grokys
Copy link
Contributor

@grokys grokys commented Feb 13, 2017

Thanks @BOT-Man-JL - this indeed sounds like a bug!
@grokys grokys added this to Not Started in 2.2.0.8 Feb 16, 2017
@grokys
Copy link
Contributor

@grokys grokys commented Feb 20, 2017

It looks like this can't be done on VS2015 as IGitRepositoriesExt.Clone doesn't return the progress of the clone operation. However I should be possible on VS2017 via the new IGitActionsExt.CloneAsync API.
@grokys grokys removed this from Not Started in 2.2.0.8 Feb 20, 2017
@grokys grokys added this to In Progress in 2.2.0.8 Feb 22, 2017
grokys added a commit that referenced this issue Feb 23, 2017
@grokys
In order to fix #800, we need to pass a progress object to `IGitActio…
Loading status checks…
4d35734 
…nsExt.CloneAsync`. This was not easy before as the call to `CloneAsync` was hidden in the Clone button command in RepositoryCloneService. This commit:

- Stops the `RepositoryCloneViewModel` from doing the clone itself
- Adds a `DialogService` to show the clone dialogs and return their results
- Adds a "progress" parameter to `RepositoryCloneService.CloneRepository` and `IVSGitServices.Clone`
- Makes the connect and start pages use the dialog service to show the dialog and then call the clone service

This commit also fixes #849:

- `RepositoryCloneService.CloneRepository` and `IVSGitServices.Clone` now return a task that doesn't complete until the clone is complete
- Changes `GitHubConnectSection` to have a `Clone` command which disabled itself while the clone is in progress.
@grokys grokys mentioned this issue Feb 23, 2017
Merged
@grokys grokys closed this in #881 Feb 27, 2017
@paladique paladique moved this from In Progress to Done in 2.2.0.8 Feb 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
2.2.0.8
Done
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Pass progress object to TE clone.
2 participants
@grokys @BOT-Man-JL
You can’t perform that action at this time.