Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
GitHub provider on Start Page should use the new Clone API #800
Comments
|
@prasethu Thanks for the heads up, we'll get this included on our roadmap! |
|
@prasethu - I've implemented that here: 49a16ae#diff-37b2ed98a57be40299d610a06bbc51b8R68 This seems to work, however I'm not sure if we should be creating a new |
|
@grokys Sorry about the late response but yes you should be passing it over to the clone api. |
…nsExt.CloneAsync`. This was not easy before as the call to `CloneAsync` was hidden in the Clone button command in RepositoryCloneService. This commit: - Stops the `RepositoryCloneViewModel` from doing the clone itself - Adds a `DialogService` to show the clone dialogs and return their results - Adds a "progress" parameter to `RepositoryCloneService.CloneRepository` and `IVSGitServices.Clone` - Makes the connect and start pages use the dialog service to show the dialog and then call the clone service This commit also fixes #849: - `RepositoryCloneService.CloneRepository` and `IVSGitServices.Clone` now return a task that doesn't complete until the clone is complete - Changes `GitHubConnectSection` to have a `Clone` command which disabled itself while the clone is in progress.
In VS 2017, we've introduced a new Clone API that enables cloning in Team Explorer and returns progress through an IProgress.
To enable the Start Page to display progress in the status bar, the GitHub provider should pass on the IProgress to the Clone API.
A sample usage of the new Clone API can be found here:
https://github.com/prasethu/CloneAPISample
Specifically this file: CloneAPISample/VSIXProject2/Command1.cs
The text was updated successfully, but these errors were encountered: