Hi @abuchholtzau,

Yes this is currently failing because we're using a hack to detect the current VS theme and mistakenly identifying the high-contrast theme for a light theme.

The code to detect the current theme is here:

https://github.com/github/VisualStudio/blob/master/src/GitHub.VisualStudio.UI/Colors.cs#L35

There must be a better way to detect the current VS theme, but all I've found from googling are methods that involve reading a registry key, which strikes me as rather non-future-proof. How should we be detecting the current theme?

@prasethu can you help advise a better way to detect the VS theme?

@abuchholtzau @grokys The right way to do this would be to apply the Platform button style in XAML directly on your button.

<UserControl xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:vsfx="clr-namespace: Microsoft.VisualStudio.Shell;assembly=Microsoft.VisualStudio.Shell.15.0"> <Button Style="{DynamicResource {x:Static vsfx:VsResourceKeys.ButtonStyleKey}}" /> </UserControl>

Thanks @prasethu, it turns out we were overriding the default button style. Removing our overridden default button styled fixed it.

It would still be useful if there was a decent way to detect the current theme, but that's now a separate issue.

@grokys Why do you want to know what the current theme is? Your code should be agnostic to themes because we can add or change themes as we please.

@grokys If this is specific to HighContrast, then there is the standard way:
SystemParameters.HighContrast