Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub pane navigation broken #628

Closed
grokys opened this issue Oct 24, 2016 · 6 comments
Closed

GitHub pane navigation broken #628

grokys opened this issue Oct 24, 2016 · 6 comments

Comments

@grokys
Copy link
Contributor

@grokys grokys commented Oct 24, 2016

Now that the maintainer workflow branch has been merged to master, it's clear that navigation in the GitHub pane is broken: switching branches switches the pane back to the PR list and subsequent navigation with the back/forward/PR buttons is broken.

@StanleyGoldman
Copy link
Contributor

@StanleyGoldman StanleyGoldman commented Dec 9, 2016

I think I found an easier way to reproduce the same issue. If I navigate to a pull request, use the back button to go back to the pull request list, and then use the forward button to attempt to go back to the pull request. I get an error.

Video

@StanleyGoldman
Copy link
Contributor

@StanleyGoldman StanleyGoldman commented Dec 9, 2016

Hey @shana I made some progress on this; I could use your input.

@shana
Copy link
Collaborator

@shana shana commented Dec 9, 2016

@StanleyGoldman I won't probably be able to give you input before monday, I have a really bad cold and it's getting late here. :sick:

@StanleyGoldman
Copy link
Contributor

@StanleyGoldman StanleyGoldman commented Dec 9, 2016

@StanleyGoldman
Copy link
Contributor

@StanleyGoldman StanleyGoldman commented Dec 10, 2016

Playing around some more, I discovered this as well.

Error

@grokys
Copy link
Contributor Author

@grokys grokys commented Dec 10, 2016

I understand. Rest well!

I read this as "I understand REST well". Was going to say: you're probably the only one! ;)

@shana shana closed this in #752 Jan 4, 2017
@grokys grokys moved this from In Progress to Done in Maintainer workflow Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants
You can’t perform that action at this time.