Skip to content

/ VisualStudio

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Occasional exception in TrackingCollection. #597

Closed
grokys opened this issue Oct 13, 2016 · 4 comments
Closed

Occasional exception in TrackingCollection. #597

grokys opened this issue Oct 13, 2016 · 4 comments
Labels
P1 - Blocks Beta bug crash
Projects
Maintainer workflow
Milestone
Maintainer Workfl...

Comments

@grokys
Copy link
Contributor

@grokys grokys commented Oct 13, 2016 •
edited

I get very occasional exceptions in TrackingCollection - usually when the PR list is updating. Here's the details:

At TrackingCollection.cs line 476

System.ObjectDisposedException occurred
  HResult=-2146232798
  Message=Cannot access a disposed object.
Object name: 'TrackingCollection'.
  ObjectName=TrackingCollection
  Source=GitHub.Exports.Reactive
  StackTrace:
       at GitHub.Collections.TrackingCollection`1.RemoveItem(T item) in D:\projects\VisualStudio\src\GitHub.Exports.Reactive\Collections\TrackingCollection.cs:line 476
  InnerException:

As you can see, the stack trace shows only the current method: RemoveItem.

This crashes VS.
@grokys grokys changed the title Occasion exception in TrackingCollection. Occasional exception in TrackingCollection. Oct 13, 2016
@shana
Copy link
Collaborator

@shana shana commented Oct 13, 2016

Feels like a race condition between disposal of the current listeners in preparation for processing the new results and the current list still processing.
@StanleyGoldman
Copy link
Contributor

@StanleyGoldman StanleyGoldman commented Oct 26, 2016

I tried my best to reproduce this bug or see how it could happen and I checked the master and maintainer-workflow-diff branches. The only usages of RemoveItem() I could find are wrapped in try/catch blocks that swallow exceptions of type ObjectDisposedException. I'm not sure how you are getting that exception.
@paladique paladique added this to the Maintainer Workflow: The Road to MVP milestone Dec 6, 2016
@grokys
Copy link
Contributor Author

@grokys grokys commented Dec 8, 2016

Still getting this occasionally. The exception seems to be swallowed so it doesn't crash VS, but I'm worried that it might break the PR list.
@StanleyGoldman StanleyGoldman mentioned this issue Dec 14, 2016
Merged
@grokys
Copy link
Contributor Author

@grokys grokys commented Jan 3, 2017

Fixed by #742.
@grokys grokys closed this Jan 3, 2017
@grokys grokys moved this from Not Started to Done in Maintainer workflow Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 - Blocks Beta bug crash
Projects
Maintainer workflow
Done
Milestone
Maintainer Workflow: Beta
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@shana @StanleyGoldman @paladique @grokys
You can’t perform that action at this time.