Skip to content

/ VisualStudio

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Username error icon displays by default #307

Closed
mponce1 opened this issue May 18, 2016 · 3 comments
Closed

Username error icon displays by default #307

mponce1 opened this issue May 18, 2016 · 3 comments
Labels
bug

Comments

@mponce1
Copy link
Contributor

@mponce1 mponce1 commented May 18, 2016

Steps to reproduce:

  1. Open visual studio
  2. Go to connect page
  3. Click on Github -> Connect

Expected result: Username error icon only displays after user tabs away from field or enters an invalid value.
Actual result: Error displays immediately when it opens. Tabbing away from the field clears the icon.

screen shot 2016-05-18 at 3 24 48 pm 1
@shana
Copy link
Collaborator

@shana shana commented May 18, 2016

@grokys Could this be related to #285?
@mponce1
Copy link
Contributor Author

@mponce1 mponce1 commented May 19, 2016

Also happens on Enterprise if you're already signed into Github and you go to Manage Connections -> Connect to Github.

screen shot 2016-05-18 at 5 06 50 pm
@mponce1 mponce1 mentioned this issue May 19, 2016
Closed
@grokys
Copy link
Contributor

@grokys grokys commented May 19, 2016

Ignore my previous comment - yes I think this was caused by #285.
grokys added a commit that referenced this issue May 19, 2016
@grokys
Only display error adorner after user interaction.
Loading status checks…
00beae9 
Fixes #307.
@grokys grokys mentioned this issue May 19, 2016
Merged
@shana shana closed this in #313 May 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@shana @grokys @mponce1
You can’t perform that action at this time.