Skip to content

/ VisualStudio

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub context menus show up when in non-github repos #301

Closed
shana opened this issue May 16, 2016 · 3 comments
Closed

GitHub context menus show up when in non-github repos #301

shana opened this issue May 16, 2016 · 3 comments
Assignees
@paladique
Labels
bug

Comments

@shana
Copy link
Collaborator

@shana shana commented May 16, 2016

Reported by @acangialosi

When working on a project hosted on VSTS, GitHub Create/Copy link context menus are showing up, and they shouldn't be.
@paladique
Copy link
Collaborator

@paladique paladique commented May 27, 2016 •
edited

I made a new project, uploaded that to VSTS and was able to reproduce this.
2016-05-27 2

Other scenarios where context menu still shows up

  1. Logged out of extension, even after restarting
@paladique paladique mentioned this issue May 27, 2016
Merged
@paladique paladique added the bug label May 31, 2016
@shana shana closed this in #334 Jun 16, 2016
@shana shana mentioned this issue Jun 22, 2016
Closed
3 of 3 tasks complete
@paladique paladique mentioned this issue Jun 23, 2016
Merged
@femisimon
Copy link

@femisimon femisimon commented Oct 24, 2016 •
edited

Description

Files not hosted on GitHub when user isn't logged in shouldn't provide the following GitHub Context Menu Option:

  • Open on Github
  • Copy link to clipboard

Although clicking on the options generates a 404 page on dot com, Our manifest requires this options not to be visible in this scenario.

GitHub Extension version: v2.0.15.1
Visual Studio version: 14.0.25424.00 Update 3

Steps to reproduce

  • Launch VS and log out if already logged in
  • Open a C# file that isn't hosted on GitHub
  • Select any text in c# file and Right-click.
  • Open on Github and Copy link to clipboard is visible in the context menu

Expected result - Open on Github and Copy link to clipboard should not be visible in the context menu

Actual result - Open on Github and Copy link to clipboard is visible in the context menu
@paladique paladique reopened this Oct 24, 2016
@femisimon femisimon mentioned this issue Oct 24, 2016
Closed
@grokys
Copy link
Contributor

@grokys grokys commented Feb 15, 2017

Seems to be fixed.
@grokys grokys closed this Feb 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paladique paladique

Labels
bug
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@shana @paladique @grokys @femisimon
You can’t perform that action at this time.