Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Publish button disabled until user clicks repository name #279
Comments
grokys
added a commit
that referenced
this issue
May 30, 2016
From `IRepositoryPublishViewModel`. Seems to not be needed and was causing #279. The default repository name was being placed directly into `RepositoryPublishControl.nameText` in the control which meant: - it was only written to `RepositoryName` when the user clicked on the `nameText` control - which meant that `RepositoryName` was up until that point null - which meant that the validation for it was failing - which meant the "Publish" button was disabled. This commit just sets the `RepositoryName` to the default in the VM ctor meaning that that name gets immediately validated. `DefaultRepositoryName` didn't seem to be used anywhere else, so I removed it. cc: @haacked for a sanity check because it looks like you wrote this. Fixes #279
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce:
1.Create new local repository2.Go to publish (double click repository, sync, publish to github)3.Click repository name field, then away from it (notice button is now enabled)Expected result: Publish button available by default.
Actual result: Publish button is disabled until user clicks repository name field.
The text was updated successfully, but these errors were encountered: