Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect casing in the clone url owner causes issues #1804

Closed
StanleyGoldman opened this issue Jul 25, 2018 · 0 comments
Closed

Incorrect casing in the clone url owner causes issues #1804

StanleyGoldman opened this issue Jul 25, 2018 · 0 comments
Labels
Milestone

Comments

@StanleyGoldman
Copy link
Contributor

@StanleyGoldman StanleyGoldman commented Jul 25, 2018

Issue

If you clone a repo using incorrect casing in the owner. Some functionalities just don't work.

  • Visual Studio is https://github.com/github/VisualStudio.git
  • If you instead clone it with https://github.com/GitHub/VisualStudio.git
The following functionalities are broken
Other suspicious code paths

Original Issue

I noticed this while working with another project...

public bool IsPullRequestFromRepository(ILocalRepositoryModel repository, PullRequestDetailModel pullRequest)
{
return pullRequest.HeadRepositoryOwner == repository.CloneUrl.Owner;
}

pullRequest.HeadRepositoryOwner is "justaprogrammer"
repository.CloneUrl.Owner is "JustAProgrammer"

image

@StanleyGoldman StanleyGoldman changed the title Pull Request Detail View is unable to identify branch is from PR Incorrect casing in the clone url owner causes issues Jul 26, 2018
@meaghanlewis meaghanlewis added this to In Progress in BUGS Jul 30, 2018
@meaghanlewis meaghanlewis added this to the 2.5.5 milestone Jul 30, 2018
BUGS automation moved this from In Progress to Done Aug 7, 2018
@meaghanlewis meaghanlewis removed this from Done in BUGS Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.