Skip to content

/ VisualStudio

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`View on GitHub` tool tray button opens PR from fork repository #1692

Closed
jcansdale opened this issue May 18, 2018 · 0 comments
Closed

`View on GitHub` tool tray button opens PR from fork repository #1692

jcansdale opened this issue May 18, 2018 · 0 comments
Labels
bug
Milestone
2.5.3

Comments

@jcansdale
Copy link
Collaborator

@jcansdale jcansdale commented May 18, 2018

  • GitHub Extension for Visual Studio version: 2.5.2
  1. Opened a fork repository
  2. PR list defaults to showing PRs forked from repository
  3. Opened a PR
  4. Clicked View on GitHub tool tray button
  5. It attempts to open a PR from the fork repository

image

  • Expected to open forked from repository.
  • This works as expected when using the View on GitHub link.
@jcansdale jcansdale added the bug label May 18, 2018
@jcansdale jcansdale mentioned this issue May 21, 2018
Merged
shana added a commit that referenced this issue May 25, 2018
@jcansdale @shana
Fix `View on GitHub` when on fork repository (#1700)
8904ee1 
Don't assume that the repository owner is the same as the local repository. When viewing PRs from upstream, the upstream owner should be used.

Use owner from viewed PR not local repository
Reuse WebUrl property in OpenOnGitHub command

Fixes #1692

Commits:

2d309f7 Fix PR detail WebUrl when on fork
		Don't assume owner is same as local repository.
d2c4669 Use WebUrl for OpenOnGitHub command
d2c4669 Change to using ToRepositoryUrl from UriString
36e699f Navigate to pull/number!
@meaghanlewis meaghanlewis added this to the 2.5.3 milestone May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.5.3
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@meaghanlewis @jcansdale
You can’t perform that action at this time.