Skip to content

/ VisualStudio

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR filter view defaults to Closed #1494

Closed
meaghanlewis opened this issue Feb 15, 2018 · 0 comments
Closed

PR filter view defaults to Closed #1494

meaghanlewis opened this issue Feb 15, 2018 · 0 comments
Labels
bug regression

Comments

@meaghanlewis
Copy link
Contributor

@meaghanlewis meaghanlewis commented Feb 15, 2018 •
edited

Steps to reproduce:

  • Open repository
  • Go to pull requests list
  • Change filter to different options (all, closed, open)
  • close VS
  • reopen VS and go back to pull requests list

Actual behavior: Pull request filter defaults to Closed
Expected behavior: Pull request filter should default to All

Gif of issue:
filter-states-not-saved-bug
@meaghanlewis meaghanlewis added this to Needs Repro in BUGS Feb 15, 2018
grokys added a commit that referenced this issue Feb 16, 2018
@grokys
Save the PR list filter settings.
Loading status checks…
0f4c604 
Somewhere along the line, the call to `SaveSettings` in `UpdateFilter` got removed, causing the filter settings not to get persisted. This reinstates that call.

Fixes #1494
@grokys grokys mentioned this issue Feb 16, 2018
Merged
@shana shana closed this in #1498 Feb 16, 2018
BUGS automation moved this from Needs Repro to Done Feb 16, 2018
@meaghanlewis meaghanlewis removed this from Done in BUGS Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug regression
Projects
None yet
Milestone
No milestone
1 participant
@meaghanlewis
You can’t perform that action at this time.