Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Surface errors when loading PR details. #1059
Merged
Conversation
- Added a new `IHasErrorState` interface for view models - Updated ViewBase to track the `IHasErrorState.ErrorMessage` property and display the error message when non-null - Catch exceptions when loading `PullRequestDetailsViewModel`
|
I was able to test by loading the PR list, turning off WiFi and clicking on a PR. The following message appeared.
It's nice to see when something has gone wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
When an error occurs loading PR details, currently the spinner just spins forever with no indication of an error. This PR adds a simple error display to the view which can easily be reused by other views.
IHasErrorStateinterface for view modelsIHasErrorState.ErrorMessageproperty and display the error message when non-nullPullRequestDetailsViewModelTo test:
Currently looks like this:
Could probably do with some beautification!
Not addressed in this PR
These are rather more involved and so will be addressed in another PR.
Fixes #1049