Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide copy/open link when file not hosted on repo. #859

Merged
merged 4 commits into from Feb 23, 2017

Conversation

@grokys
Copy link
Contributor

@grokys grokys commented Feb 15, 2017

Check to see if the current file is located in the active repository and only show "Open on GitHub" and "Copy link to clipboard" context menus if it is.

Fixes #530.

Check to see if the current file is located in the active repository and
only show "Open on GitHub" and "Copy link to clipboard" context menus if
it is.

Fixes #530.
@grokys grokys requested review from paladique and jcansdale Feb 15, 2017
Copy link
Collaborator

@paladique paladique left a comment

Looks/works good! 👍 Just wanted to note that when we get the blame command into master, it's going to cause a few minor conflicts but nothing major.

Copy link
Collaborator

@jcansdale jcansdale left a comment

I'm wondering if submodules will complicate this? It looks like we're comparing the path to the active repo in VS rather than the repo the file might be in (if it's in a submodule).

@grokys
Copy link
Contributor Author

@grokys grokys commented Feb 23, 2017

@jcansdale yeah, we don't currently consider submodules when generating links. We should fix this, but it should be a separate PR IMO. Could you add an issue to track?

Copy link
Collaborator

@jcansdale jcansdale left a comment

Seems to work as described!

@jcansdale jcansdale merged commit a6c0748 into master Feb 23, 2017
3 of 5 checks passed
3 of 5 checks passed
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
GitHub CLA @grokys has accepted the GitHub Contributor License Agreement.
Details
VisualStudio Build #5615846 succeeded in 82s
Details
jenkins/build_log Jenkins Build Log
Details
@jcansdale jcansdale deleted the fixes/530-hide-open-copy-link branch Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.