Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
MVVM-ize things (attempt 2) #1367
Merged
Conversation
...instead of `IGitHubServiceProvider` to create view models in `GitHubDialogWindowViewModel`. Also added some doc comments.
And use it instead of defining `LoginView` and `NavigationView` separately.
MEF requires an array here.
When the page to be navigated to in the GitHub pane is the current page, do nothing.
Conflicts: src/GitHub.App/ViewModels/GitHubPane/PullRequestDetailViewModel.cs
`IVSGitExt.ActiveRepositoriesChanged` isn't notified on the UI thread which breaks things. Switch to the main thread when refreshing due to a notification from this.
|
LGTM! |
grokys
added a commit
that referenced
this pull request
Dec 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
#1346 was targeting the wrong branch (it was targeting #1353) when I pushed. This PR is exactly the same as #1346 except targeting
master.