Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upbuild: Support docker to build binary package #1112
Merged
Conversation
rzr
added a commit
to CrossStream/node-sqlite3
that referenced
this pull request
Jan 27, 2019
This can be then declined for several arch Change-Id: I79000463955d16eec8809c870f7d02c60da53432 Bug: mapbox#418 Forwarded: mapbox#1112 mapbox#1028 Origin: https://github.com/tizenteam/node-sqlite3 Signed-off-by: Philippe Coval <p.coval@samsung.com>
|
The PR is sound, some nitpicks. |
.dockerignore
Outdated
| # Build artifacts | ||
| /build | ||
| node_modules/ | ||
| static/js/lib/stm_web.min.js |
This comment has been minimized.
This comment has been minimized.
.dockerignore
Outdated
| # Run-time artifacts | ||
| .node-persist/ | ||
| config/local.js | ||
| static/uploads |
This comment has been minimized.
This comment has been minimized.
|
@rzr Thank you for the contributions. |
cb805d1
to
b59ad31
rzr
added a commit
to CrossStream/node-sqlite3
that referenced
this pull request
Jan 28, 2019
This can be then declined for several arch Change-Id: I79000463955d16eec8809c870f7d02c60da53432 Bug: mapbox#418 Forwarded: mapbox#1112 mapbox#1028 Origin: https://github.com/tizenteam/node-sqlite3 Signed-off-by: Philippe Coval <p.coval@samsung.com>
rzr
added a commit
to CrossStream/node-sqlite3
that referenced
this pull request
Jan 28, 2019
Just shared as demo May be changed Change-Id: I79000463955d16eec8809c870f7d02c60da53432 Bug: mapbox#418 Forwarded: mapbox#1112 mapbox#1028 Origin: https://github.com/tizenteam/node-sqlite3 Signed-off-by: Philippe Coval <p.coval@samsung.com>
Usage: ``` docker build . ``` This can be then declined for several arch, elsewhere. Change-Id: I79000463955d16eec8809c870f7d02c60da53432 Bug: #418 Forwarded: #1112 #1028 Origin: https://github.com/tizenteam/node-sqlite3 Signed-off-by: Philippe Coval <p.coval@samsung.com>
b59ad31
to
4d19c57
|
Thank you @rzr |
tkurki
commented
Feb 23, 2019
|
Now that this is merged what's the next step? How do you use this? My ultimate goal is #418. |
rzr
added a commit
to CrossStream/node-sqlite3
that referenced
this pull request
Sep 30, 2019
Just shared as demo May be changed Change-Id: I79000463955d16eec8809c870f7d02c60da53432 Bug: mapbox#418 Forwarded: mapbox#1112 mapbox#1028 Origin: https://github.com/tizenteam/node-sqlite3 Signed-off-by: Philippe Coval <p.coval@samsung.com>
rzr
added a commit
to CrossStream/node-sqlite3
that referenced
this pull request
Jul 1, 2020
Just shared as demo May be changed Change-Id: I79000463955d16eec8809c870f7d02c60da53432 Bug: mapbox#418 Forwarded: mapbox#1112 mapbox#1028 Origin: https://github.com/tizenteam/node-sqlite3 Signed-off-by: Philippe Coval <p.coval@samsung.com>
rzr
added a commit
to CrossStream/node-sqlite3
that referenced
this pull request
Jul 1, 2020
Just shared as demo May be changed Change-Id: I79000463955d16eec8809c870f7d02c60da53432 Bug: mapbox#418 Forwarded: mapbox#1112 mapbox#1028 Origin: https://github.com/tizenteam/node-sqlite3 Signed-off-by: Philippe Coval <p.coval@samsung.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
rzr commentedJan 27, 2019
•
edited
Change-Id: I79000463955d16eec8809c870f7d02c60da53432
Bug: #418
Forwarded: #1028
Origin: https://github.com/tizenteam/node-sqlite3
Signed-off-by: Philippe Coval p.coval@samsung.com