Skip to content

/ VisualStudio

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing the experimental feature toggle for forking #2093

Merged
merged 6 commits into from Dec 6, 2018
Merged

Removing the experimental feature toggle for forking #2093

merged 6 commits into from Dec 6, 2018

Conversation

@StanleyGoldman
Copy link
Contributor

@StanleyGoldman StanleyGoldman commented Nov 30, 2018

No description provided.

@StanleyGoldman
Removing the experimental feature toggle for forking
Verified
This commit was signed with a verified signature.
StanleyGoldman Stanley Goldman
GPG key ID: 7728F3B9BD13C8C3 Learn about signing commits
Loading status checks…
ca3456c
@StanleyGoldman StanleyGoldman requested review from grokys and jcansdale Nov 30, 2018
@meaghanlewis meaghanlewis added this to the 2.6.0 milestone Nov 30, 2018
@StanleyGoldman
Merge branch 'master' into remove-fork-experimental-setting
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c2dd90e
@StanleyGoldman
Forgot to remove some code that handled the view
Verified
This commit was signed with a verified signature.
StanleyGoldman Stanley Goldman
GPG key ID: 7728F3B9BD13C8C3 Learn about signing commits
Loading status checks…
8501b79
@StanleyGoldman
Merge branch 'master' into remove-fork-experimental-setting
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
416f814
@meaghanlewis
Copy link
Contributor

@meaghanlewis meaghanlewis commented Dec 4, 2018

Tested this on VS2017 and 2019. Functionality wise this looks good. A couple things I noticed were:

  • when there are less than 3 organizations/users available to fork the highlight around the box extends very long
  • sometimes organizations/users available don't load or just take a really long time (>60 seconds)
@jcansdale
jcansdale approved these changes Dec 5, 2018
View changes
Copy link
Collaborator

@jcansdale jcansdale left a comment •
edited

Looks good. 👍 I'm looking forward to having this one available by default. 🙂
jcansdale added 2 commits Dec 5, 2018
@jcansdale
Merge branch 'master' into remove-fork-experimental-setting
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8505fcc
@jcansdale
Merge branch 'master' into remove-fork-experimental-setting
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
98a1c09
@StanleyGoldman StanleyGoldman merged commit d2b35ab into master Dec 6, 2018
4 checks passed
4 checks passed
MSBuild Log 0 errors - 1540 warnings
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
github.VisualStudio Build #20181206.7 succeeded
Details
@StanleyGoldman StanleyGoldman deleted the remove-fork-experimental-setting branch Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcansdale jcansdale

@grokys grokys

Assignees
No one assigned
Labels
Ready for Review verified
Projects
None yet
Milestone
2.6.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@StanleyGoldman @meaghanlewis @jcansdale
You can’t perform that action at this time.