➜

This issue tracker will soon become read-only and move to GitHub.
For a smoother transition, remember to log in and link your GitHub username to your profile.
For more information, see this post about the migration.

classification
Title: Dead assignment in pattern_subx
Type: performance Stage: resolved
Components: Regular Expressions Versions: Python 3.9
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: alex.henrie, ezio.melotti, mrabarnett, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2020-01-09 04:22 by alex.henrie, last changed 2020-01-09 06:29 by serhiy.storchaka. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 17915 merged alex.henrie, 2020-01-09 04:23
Messages (3)
msg359653 - (view) Author: Alex Henrie (alex.henrie) * Date: 2020-01-09 04:22 
The function pattern_subx currently sets the variable b to charsize, but that variable is reset to STATE_OFFSET(&state, state.start) before it is ever used.
msg359655 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2020-01-09 06:27 
New changeset 1a183faccbe5c32c367dbced721a25c1444dc5c1 by Serhiy Storchaka (Alex Henrie) in branch 'master':
bpo-39271: Remove dead assignment from pattern_subx (GH-17915)
https://github.com/python/cpython/commit/1a183faccbe5c32c367dbced721a25c1444dc5c1
msg359656 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2020-01-09 06:29 
Thank you Alex.
History
Date User Action Args
2020-01-09 06:29:10serhiy.storchakasetstatus: open -> closed
resolution: fixed
messages: + msg359656

stage: patch review -> resolved
2020-01-09 06:27:58serhiy.storchakasetnosy: + serhiy.storchaka
messages: + msg359655
2020-01-09 04:23:33alex.henriesetkeywords: + patch
stage: patch review
pull_requests: + pull_request17327
2020-01-09 04:22:03alex.henriecreate