Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-28367: Add additional baud rates for termios #13142
Merged
+46
−0
Conversation
This comment has been minimized.
This comment has been minimized.
|
requesting review from @pitrou |
This comment has been minimized.
This comment has been minimized.
|
Hi, @tonybaloney. The developer's guide states that one should provide attribution to the original patch author when converting a patch to a pull request. |
This comment has been minimized.
This comment has been minimized.
|
thanks, I put it in the news entry. I wasn't aware of the commit message requirement. https://github.com/python/cpython/pull/13142/files#diff-1c47238a6c1f8e56b2135b189fd52773R13 |
This comment has been minimized.
This comment has been minimized.
|
Revised commit message |
This comment has been minimized.
This comment has been minimized.
|
@Yhg1s please can you review (going by experts index) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
tonybaloney commentedMay 6, 2019
•
edited by bedevere-bot
https://bugs.python.org/issue28367