Skip to content

/ trojan

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Build Failed on GNU/Hurd #183

Closed
GreaterFire opened this issue Dec 28, 2019 · 1 comment
Closed

[BUG] Build Failed on GNU/Hurd #183

GreaterFire opened this issue Dec 28, 2019 · 1 comment
Labels
bug good first issue

Comments

@GreaterFire
Copy link
Member

@GreaterFire GreaterFire commented Dec 28, 2019

trojan/src/core/service.cpp

Lines 29 to 31 in 18763b7

#ifdef __MACH__
#include <Security/Security.h>
#endif // __MACH__

In GNU/Hurd, __MACH__ is also defined, but the macOS specific header file doesn't exist.
@wongsyrone
Copy link
Contributor

@wongsyrone wongsyrone commented Dec 28, 2019

Some applications put Apple Darwin-specific code inside #ifdef __MACH__ guards. Such guard is clearly not enough, since not only Apple uses Mach as a kernel. This should be replaced by #if defined(__MACH__) && defined(__APPLE__)

https://www.gnu.org/software/hurd/hurd/porting/guidelines.html
GreaterFire added a commit that referenced this issue Dec 29, 2019
@GreaterFire
Change all __MACH__ to __APPLE__ (closes #183)
Loading status checks…
79d5c65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@wongsyrone @GreaterFire
You can’t perform that action at this time.